Merge pull request #64455 from xedin/remove-generate-constraints-casestmt

[ConstraintSystem] NFC: Remove obsolete `generateConstraints(CaseStmt *, ...)`

Author: xedin

include/swift/Sema/ConstraintSystem.h

@@ -4298,17 +4298,6 @@ class ConstraintSystem {
   [[nodiscard]]
   bool generateConstraints(StmtCondition condition, DeclContext *dc);
 
-  /// Generate constraints for a case statement.
-  ///
-  /// \param subjectType The type of the "subject" expression in the enclosing
-  /// switch statement.
-  ///
-  /// \returns true if there was an error in constraint generation, false
-  /// if generation succeeded.
-  [[nodiscard]]
-  bool generateConstraints(CaseStmt *caseStmt, DeclContext *dc,
-                           Type subjectType, ConstraintLocator *locator);
-
   /// Generate constraints for a given set of overload choices.
   ///
   /// \param constraints The container of generated constraint choices.

lib/Sema/CSGen.cpp

@@ -4781,80 +4781,6 @@ bool ConstraintSystem::generateConstraints(StmtCondition condition,
   return false;
 }
 
-bool ConstraintSystem::generateConstraints(
-    CaseStmt *caseStmt, DeclContext *dc, Type subjectType,
-    ConstraintLocator *locator) {
-  // Pre-bind all of the pattern variables within the case.
-  bindSwitchCasePatternVars(dc, caseStmt);
-
-  for (auto &caseLabelItem : caseStmt->getMutableCaseLabelItems()) {
-    // Resolve the pattern.
-    auto *pattern = caseLabelItem.getPattern();
-    if (!caseLabelItem.isPatternResolved()) {
-      pattern = TypeChecker::resolvePattern(
-          pattern, dc, /*isStmtCondition=*/false);
-      if (!pattern)
-        return true;
-    }
-
-    // Generate constraints for the pattern, including one-way bindings for
-    // any variables that show up in this pattern, because those variables
-    // can be referenced in the guard expressions and the body.
-    Type patternType = generateConstraints(
-        pattern, locator, /* bindPatternVarsOneWay=*/true,
-        /*patternBinding=*/nullptr, /*patternBindingIndex=*/0);
-
-    // Convert the subject type to the pattern, which establishes the
-    // bindings.
-    addConstraint(
-        ConstraintKind::Conversion, subjectType, patternType, locator);
-
-    // Generate constraints for the guard expression, if there is one.
-    Expr *guardExpr = caseLabelItem.getGuardExpr();
-    if (guardExpr) {
-      auto &ctx = dc->getASTContext();
-      SyntacticElementTarget guardTarget(
-          guardExpr, dc, CTP_Condition, ctx.getBoolType(), /*discarded*/ false);
-
-      if (generateConstraints(guardTarget))
-        return true;
-
-      guardExpr = guardTarget.getAsExpr();
-      setTargetFor(guardExpr, guardTarget);
-    }
-
-    // Save this info.
-    setCaseLabelItemInfo(&caseLabelItem, {pattern, guardExpr});
-
-    // For any pattern variable that has a parent variable (i.e., another
-    // pattern variable with the same name in the same case), require that
-    // the types be equivalent.
-    pattern->forEachNode([&](Pattern *pattern) {
-      auto namedPattern = dyn_cast<NamedPattern>(pattern);
-      if (!namedPattern)
-        return;
-
-      auto var = namedPattern->getDecl();
-      if (auto parentVar = var->getParentVarDecl()) {
-        addConstraint(
-            ConstraintKind::Equal, getType(parentVar), getType(var),
-            getConstraintLocator(
-              locator,
-              LocatorPathElt::PatternMatch(namedPattern)));
-      }
-    });
-  }
-
-  // Bind the types of the case body variables.
-  for (auto caseBodyVar : caseStmt->getCaseBodyVariablesOrEmptyArray()) {
-    auto parentVar = caseBodyVar->getParentVarDecl();
-    assert(parentVar && "Case body variables always have parents");
-    setType(caseBodyVar, getType(parentVar));
-  }
-
-  return false;
-}
-
 ConstraintSystem::TypeMatchResult
 ConstraintSystem::applyPropertyWrapperToParameter(
     Type wrapperType, Type paramType, ParamDecl *param, Identifier argLabel,