NCGenerics: remove ArcheType::hasRequirements

The IDE's use isn't correct under noncopyable generics and only the
constraint solver uses it. It's a misleading method now that nearly
every archetype has Copyable/Escapable requirements.

Author: kavon

include/swift/AST/Types.h

@@ -6405,11 +6405,6 @@ class ArchetypeType : public SubstitutableType,
     return *getSubclassTrailingObjects<LayoutConstraint>();
   }
 
-  /// Return true if the archetype has any requirements at all.
-  bool hasRequirements() const {
-    return !getConformsTo().empty() || getSuperclass();
-  }
-
   /// Retrieve the nested type with the given associated type.
   Type getNestedType(AssociatedTypeDecl *assocType);
 

lib/IDE/CodeCompletionResultType.cpp

@@ -396,7 +396,7 @@ static TypeRelation calculateTypeRelation(Type Ty, Type ExpectedTy,
     bool isAny = false;
     isAny |= ExpectedTy->isAny();
     isAny |= ExpectedTy->is<ArchetypeType>() &&
-             !ExpectedTy->castTo<ArchetypeType>()->hasRequirements();
+             ExpectedTy->castTo<ArchetypeType>()->getExistentialType()->isAny();
 
     if (!isAny && isConvertibleTo(Ty, ExpectedTy, /*openArchetypes=*/true,
                                   const_cast<DeclContext &>(DC)))

lib/Sema/CSApply.cpp

@@ -78,7 +78,8 @@ static bool isOpenedAnyObject(Type type) {
     return false;
 
   return (archetype->requiresClass() &&
-          !archetype->hasRequirements());
+          archetype->getConformsTo().empty() &&
+          !archetype->getSuperclass());
 }
 
 SubstitutionMap