Optimizer: add some SIL modification APIs to Context

* `insertFunctionArgument`
* `BeginAccessInst.set(accessKind:)`
* `erase(function:)`

Author: eeckstein

SwiftCompilerSources/Sources/Optimizer/PassManager/Context.swift

@@ -609,6 +609,14 @@ extension BasicBlock {
     return bridged.addFunctionArgument(type.bridged).argument as! FunctionArgument
   }
 
+  func insertFunctionArgument(atPosition: Int, type: Type, ownership: Ownership, decl: ValueDecl? = nil,
+                              _ context: some MutatingContext) -> FunctionArgument
+  {
+    context.notifyInstructionsChanged()
+    return bridged.insertFunctionArgument(atPosition, type.bridged, ownership._bridged,
+                                          (decl as Decl?).bridged).argument as! FunctionArgument
+  }
+
   func eraseArgument(at index: Int, _ context: some MutatingContext) {
     context.notifyInstructionsChanged()
     bridged.eraseArgument(index)
@@ -791,6 +799,14 @@ extension MarkDependenceInstruction {
   }
 }
 
+extension BeginAccessInst {
+  func set(accessKind: BeginAccessInst.AccessKind, context: some MutatingContext) {
+    context.notifyInstructionsChanged()
+    bridged.BeginAccess_setAccessKind(accessKind.rawValue)
+    context.notifyInstructionChanged(self)
+  }
+}
+
 extension TermInst {
   func replaceBranchTarget(from fromBlock: BasicBlock, to toBlock: BasicBlock, _ context: some MutatingContext) {
     context.notifyBranchesChanged()

SwiftCompilerSources/Sources/Optimizer/PassManager/ModulePassContext.swift

@@ -206,6 +206,10 @@ struct ModulePassContext : Context, CustomStringConvertible {
     }
   }
 
+  func erase(function: Function) {
+    _bridged.eraseFunction(function.bridged)
+  }
+
   func notifyFunctionTablesChanged() {
     _bridged.asNotificationHandler().notifyChanges(.functionTablesChanged)
   }

include/swift/SIL/SILBridging.h

@@ -811,6 +811,7 @@ struct BridgedInstruction {
   BRIDGED_INLINE SwiftInt BeginAccessInst_getAccessKind() const;
   BRIDGED_INLINE bool BeginAccessInst_isStatic() const;
   BRIDGED_INLINE bool BeginAccessInst_isUnsafe() const;
+  BRIDGED_INLINE void BeginAccess_setAccessKind(SwiftInt accessKind) const;
   BRIDGED_INLINE bool CopyAddrInst_isTakeOfSrc() const;
   BRIDGED_INLINE bool CopyAddrInst_isInitializationOfDest() const;
   BRIDGED_INLINE void CopyAddrInst_setIsTakeOfSrc(bool isTakeOfSrc) const;
@@ -939,8 +940,11 @@ struct BridgedBasicBlock {
   SWIFT_IMPORT_UNSAFE BRIDGED_INLINE OptionalBridgedInstruction getLastInst() const;
   BRIDGED_INLINE SwiftInt getNumArguments() const;
   SWIFT_IMPORT_UNSAFE BRIDGED_INLINE BridgedArgument getArgument(SwiftInt index) const;
-  SWIFT_IMPORT_UNSAFE  BRIDGED_INLINE BridgedArgument addBlockArgument(BridgedType type, BridgedValue::Ownership ownership) const;
-  SWIFT_IMPORT_UNSAFE  BRIDGED_INLINE BridgedArgument addFunctionArgument(BridgedType type) const;
+  SWIFT_IMPORT_UNSAFE BRIDGED_INLINE BridgedArgument addBlockArgument(BridgedType type, BridgedValue::Ownership ownership) const;
+  SWIFT_IMPORT_UNSAFE BRIDGED_INLINE BridgedArgument addFunctionArgument(BridgedType type) const;
+  SWIFT_IMPORT_UNSAFE BRIDGED_INLINE BridgedArgument insertFunctionArgument(SwiftInt atPosition, BridgedType type,
+                                                                            BridgedValue::Ownership ownership,
+                                                                            OptionalBridgedDeclObj decl) const;
   BRIDGED_INLINE void eraseArgument(SwiftInt index) const;
   BRIDGED_INLINE void moveAllInstructionsToBegin(BridgedBasicBlock dest) const;
   BRIDGED_INLINE void moveAllInstructionsToEnd(BridgedBasicBlock dest) const;

include/swift/SIL/SILBridgingImpl.h

@@ -1463,6 +1463,10 @@ bool BridgedInstruction::BeginAccessInst_isUnsafe() const {
   return getAs<swift::BeginAccessInst>()->getEnforcement() == swift::SILAccessEnforcement::Unsafe;
 }
 
+void BridgedInstruction::BeginAccess_setAccessKind(SwiftInt accessKind) const {
+  getAs<swift::BeginAccessInst>()->setAccessKind((swift::SILAccessKind)accessKind);
+}
+
 bool BridgedInstruction::CopyAddrInst_isTakeOfSrc() const {
   return getAs<swift::CopyAddrInst>()->isTakeOfSrc();
 }
@@ -1809,6 +1813,14 @@ BridgedArgument BridgedBasicBlock::addFunctionArgument(BridgedType type) const {
   return {unbridged()->createFunctionArgument(type.unbridged())};
 }
 
+BridgedArgument BridgedBasicBlock::insertFunctionArgument(SwiftInt atPosition, BridgedType type,
+                                                          BridgedValue::Ownership ownership,
+                                                          OptionalBridgedDeclObj decl) const {
+  return {unbridged()->insertFunctionArgument((unsigned)atPosition, type.unbridged(),
+                                              BridgedValue::unbridge(ownership),
+                                              decl.getAs<swift::ValueDecl>())};
+}
+
 void BridgedBasicBlock::eraseArgument(SwiftInt index) const {
   unbridged()->eraseArgument(index);
 }

include/swift/SILOptimizer/OptimizerBridging.h

@@ -262,6 +262,7 @@ struct BridgedPassContext {
   void inlineFunction(BridgedInstruction apply, bool mandatoryInline) const;
   SWIFT_IMPORT_UNSAFE BRIDGED_INLINE BridgedValue getSILUndef(BridgedType type) const;
   BRIDGED_INLINE bool eliminateDeadAllocations(BridgedFunction f) const;
+  void eraseFunction(BridgedFunction function) const;
 
   BRIDGED_INLINE bool shouldExpand(BridgedType type) const;
 

lib/SILOptimizer/Utils/OptimizerBridging.cpp

@@ -156,6 +156,11 @@ void BridgedPassContext::inlineFunction(BridgedInstruction apply, bool mandatory
                               funcBuilder, deleter);
 }
 
+void BridgedPassContext::eraseFunction(BridgedFunction function) const {
+  invocation->getPassManager()->notifyWillDeleteFunction(function.getFunction());
+  invocation->getPassManager()->getModule()->eraseFunction(function.getFunction());
+}
+
 static const irgen::TypeInfo &getTypeInfoOfBuiltin(swift::SILType type, irgen::IRGenModule &IGM) {
   SILType lowered = IGM.getLoweredType(swift::Lowering::AbstractionPattern::getOpaque(), type.getASTType());
   return IGM.getTypeInfo(lowered);