[embedded] Check ReferenceOwnership in TypeCheckAttr instead of the parser

Author: kubamracek

lib/Parse/ParseDecl.cpp

@@ -3055,14 +3055,6 @@ ParserStatus Parser::parseNewDeclAttribute(DeclAttributes &Attributes,
       AttrRange = SourceRange(Loc);
     }
 
-    // Embedded Swift prohibits weak/unowned but allows unowned(unsafe).
-    if (Context.LangOpts.hasFeature(Feature::Embedded)) {
-      if (Kind == ReferenceOwnership::Weak ||
-          Kind == ReferenceOwnership::Unowned) {
-        diagnose(Loc, diag::weak_unowned_in_embedded_swift, Kind);
-      }
-    }
-
     if (!DiscardAttribute)
       Attributes.add(
           new (Context) ReferenceOwnershipAttr(AttrRange, Kind));

lib/Sema/TypeCheckAttr.cpp

@@ -4682,6 +4682,16 @@ Type TypeChecker::checkReferenceOwnershipAttr(VarDecl *var, Type type,
     attr->setInvalid();
   }
 
+  // Embedded Swift prohibits weak/unowned but allows unowned(unsafe).
+  if (var->getASTContext().LangOpts.hasFeature(Feature::Embedded)) {
+    if (ownershipKind == ReferenceOwnership::Weak ||
+        ownershipKind == ReferenceOwnership::Unowned) {
+      Diags.diagnose(attr->getLocation(), diag::weak_unowned_in_embedded_swift,
+               ownershipKind);
+      attr->setInvalid();
+    }
+  }
+
   if (attr->isInvalid())
     return type;