AST: Make $UnsafeInheritExecutor a baseline feature.

It has been available since at least Swift 5.8.

Author: tshortli

include/swift/Basic/Features.def

@@ -145,7 +145,7 @@ LANGUAGE_FEATURE(NewCxxMethodSafetyHeuristics, 0, "Only import C++ methods that
 SUPPRESSIBLE_LANGUAGE_FEATURE(SpecializeAttributeWithAvailability, 0, "@_specialize attribute with availability")
 BASELINE_LANGUAGE_FEATURE(BuiltinAssumeAlignment, 0, "Builtin.assumeAlignment")
 BASELINE_LANGUAGE_FEATURE(BuiltinCreateTaskGroupWithFlags, 0, "Builtin.createTaskGroupWithFlags")
-SUPPRESSIBLE_LANGUAGE_FEATURE(UnsafeInheritExecutor, 0, "@_unsafeInheritExecutor")
+BASELINE_LANGUAGE_FEATURE(UnsafeInheritExecutor, 0, "@_unsafeInheritExecutor")
 SUPPRESSIBLE_LANGUAGE_FEATURE(PrimaryAssociatedTypes2, 346, "Primary associated types")
 SUPPRESSIBLE_LANGUAGE_FEATURE(UnavailableFromAsync, 0, "@_unavailableFromAsync")
 SUPPRESSIBLE_LANGUAGE_FEATURE(NoAsyncAvailability, 340, "@available(*, noasync)")

lib/AST/ASTPrinter.cpp

@@ -3027,14 +3027,6 @@ static void suppressingFeatureSpecializeAttributeWithAvailability(
   action();
 }
 
-static void suppressingFeatureUnsafeInheritExecutor(PrintOptions &options,
-                                        llvm::function_ref<void()> action) {
-  unsigned originalExcludeAttrCount = options.ExcludeAttrList.size();
-  options.ExcludeAttrList.push_back(DeclAttrKind::UnsafeInheritExecutor);
-  action();
-  options.ExcludeAttrList.resize(originalExcludeAttrCount);
-}
-
 static void suppressingFeaturePrimaryAssociatedTypes2(PrintOptions &options,
                                          llvm::function_ref<void()> action) {
   bool originalPrintPrimaryAssociatedTypes = options.PrintPrimaryAssociatedTypes;

lib/AST/FeatureSet.cpp

@@ -201,10 +201,6 @@ static bool usesFeatureSpecializeAttributeWithAvailability(Decl *decl) {
   return false;
 }
 
-static bool usesFeatureUnsafeInheritExecutor(Decl *decl) {
-  return decl->getAttrs().hasAttribute<UnsafeInheritExecutorAttr>();
-}
-
 static bool usesFeaturePrimaryAssociatedTypes2(Decl *decl) {
   if (auto *protoDecl = dyn_cast<ProtocolDecl>(decl)) {
     if (protoDecl->getPrimaryAssociatedTypes().size() > 0)

test/ModuleInterface/features.swift

@@ -8,6 +8,7 @@
 // RUN:   --implicit-check-not "\$MarkerProtocol" \
 // RUN:   --implicit-check-not "\$Sendable" \
 // RUN:   --implicit-check-not "\$InheritActorContext" \
+// RUN:   --implicit-check-not "\$UnsafeInheritExecutor" \
 // RUN:   < %t/FeatureTest.swiftinterface
 
 // REQUIRES: concurrency
@@ -134,17 +135,16 @@ public func stage(with actor: MyActor) { }
 // CHECK:     func asyncIsh
 public func asyncIsh(@_inheritActorContext operation: @Sendable @escaping () async -> Void) { }
 
-// CHECK:     #if compiler(>=5.3) && $UnsafeInheritExecutor
 // CHECK:     @_unsafeInheritExecutor public func unsafeInheritExecutor() async
 @_unsafeInheritExecutor
 public func unsafeInheritExecutor() async {}
 
-// CHECK:     #elseif compiler(>=5.3) && $SpecializeAttributeWithAvailability
+// CHECK:     #if compiler(>=5.3) && $SpecializeAttributeWithAvailability
 // CHECK:     @_specialize{{.*}}
-// CHECK:     public func multipleSuppressible<T>(value: T) async
+// CHECK:     public func unsafeInheritExecutorAndSpecialize<T>(value: T) async
 @_unsafeInheritExecutor
 @_specialize(exported: true, availability: SwiftStdlib 5.1, *; where T == Int)
-public func multipleSuppressible<T>(value: T) async {}
+public func unsafeInheritExecutorAndSpecialize<T>(value: T) async {}
 
 // CHECK:      #if compiler(>=5.3) && $UnavailableFromAsync
 // CHECK-NEXT: @_unavailableFromAsync(message: "Test") public func unavailableFromAsyncFunc()