Move the longsections argument to build.ps1

Author: Steelskin

Runtimes/Core/CMakeLists.txt

@@ -181,7 +181,7 @@ add_compile_options(
 # We cannot selectively filter the linker warnings as we do not use the MSVC
 # frontned and `clang-cl` (and `clang`) currently do not support `/WX:nnnn`. As
 # a compromise, treat all linker warnings as errors.
-add_link_options($<$<PLATFORM_ID:Windows>:LINKER:/WX,/IGNORE:longsections>)
+add_link_options($<$<PLATFORM_ID:Windows>:LINKER:/WX>)
 
 add_compile_options(
   $<$<COMPILE_LANGUAGE:Swift>:-explicit-module-build>

Runtimes/Overlay/CMakeLists.txt

@@ -93,7 +93,7 @@ include(ExperimentalFeatures)
 # We cannot selectively filter the linker warnings as we do not use the MSVC
 # frontned and `clang-cl` (and `clang`) currently do not support `/WX:nnnn`. As
 # a compromise, treat all linker warnings as errors.
-add_link_options($<$<PLATFORM_ID:Windows>:LINKER:/WX,/IGNORE:longsections>)
+add_link_options($<$<PLATFORM_ID:Windows>:LINKER:/WX>)
 
 include(ExperimentalFeatures)
 

Runtimes/Supplemental/Differentiation/CMakeLists.txt

@@ -87,7 +87,7 @@ add_compile_options(
 # a compromise, treat all linker warnings as errors.
 # FIXME(#83444) - enable this once we fix DLL storage for
 # `_fatalErrorForwardModeDifferentiationDisabled`
-# add_link_options($<$<PLATFORM_ID:Windows>:LINKER:/WX,/IGNORE:longsections>)
+# add_link_options($<$<PLATFORM_ID:Windows>:LINKER:/WX>)
 
 if(SwiftDifferentiation_ENABLE_VECTOR_TYPES)
   gyb_expand(SIMDDifferentiation.swift.gyb SIMDDifferentiation.swift)

Runtimes/Supplemental/Distributed/CMakeLists.txt

@@ -97,7 +97,7 @@ add_compile_options(
 # We cannot selectively filter the linker warnings as we do not use the MSVC
 # frontned and `clang-cl` (and `clang`) currently do not support `/WX:nnnn`. As
 # a compromise, treat all linker warnings as errors.
-add_link_options($<$<PLATFORM_ID:Windows>:LINKER:/WX,/IGNORE:longsections>)
+add_link_options($<$<PLATFORM_ID:Windows>:LINKER:/WX>)
 
 add_library(swiftDistributed
   DistributedActor.cpp

Runtimes/Supplemental/Observation/CMakeLists.txt

@@ -82,7 +82,7 @@ add_compile_options(
 # We cannot selectively filter the linker warnings as we do not use the MSVC
 # frontned and `clang-cl` (and `clang`) currently do not support `/WX:nnnn`. As
 # a compromise, treat all linker warnings as errors.
-add_link_options($<$<PLATFORM_ID:Windows>:LINKER:/WX,/IGNORE:longsections>)
+add_link_options($<$<PLATFORM_ID:Windows>:LINKER:/WX>)
 
 add_library(swiftObservation
   Sources/Observation/Locking.swift

Runtimes/Supplemental/StringProcessing/CMakeLists.txt

@@ -64,7 +64,7 @@ add_compile_options(
 # We cannot selectively filter the linker warnings as we do not use the MSVC
 # frontned and `clang-cl` (and `clang`) currently do not support `/WX:nnnn`. As
 # a compromise, treat all linker warnings as errors.
-add_link_options($<$<PLATFORM_ID:Windows>:LINKER:/WX,/IGNORE:longsections>)
+add_link_options($<$<PLATFORM_ID:Windows>:LINKER:/WX>)
 
 add_subdirectory(_RegexParser)
 add_subdirectory(_StringProcessing)

Runtimes/Supplemental/Synchronization/CMakeLists.txt

@@ -100,7 +100,7 @@ add_compile_options(
 # We cannot selectively filter the linker warnings as we do not use the MSVC
 # frontned and `clang-cl` (and `clang`) currently do not support `/WX:nnnn`. As
 # a compromise, treat all linker warnings as errors.
-add_link_options($<$<PLATFORM_ID:Windows>:LINKER:/WX,/IGNORE:longsections>)
+add_link_options($<$<PLATFORM_ID:Windows>:LINKER:/WX>)
 
 gyb_expand(Atomics/AtomicIntegers.swift.gyb Atomics/AtomicIntegers.swift)
 gyb_expand(Atomics/AtomicStorage.swift.gyb Atomics/AtomicStorage.swift)

Runtimes/Supplemental/Volatile/CMakeLists.txt

@@ -76,7 +76,7 @@ add_compile_options(
 # We cannot selectively filter the linker warnings as we do not use the MSVC
 # frontend and `clang-cl` (and `clang`) currently do not support `/WX:nnnn`. As
 # a compromise, treat all linker warnings as errors.
-add_link_options($<$<PLATFORM_ID:Windows>:LINKER:/WX,/IGNORE:longsections>)
+add_link_options($<$<PLATFORM_ID:Windows>:LINKER:/WX>)
 
 add_library(swift_Volatile
   Volatile.swift)

utils/build.ps1

@@ -1608,6 +1608,16 @@ function Build-CMakeProject {
             } else {
               @("/DEBUG")
             }
+
+            # The linker flags are shared across every language, and `/IGNORE:longsections` is an
+            # `lld-link.exe` argument, not `link.exe`, so this can only be enabled with the GNU
+            # driver, which guarantees we are using `lld-link.exe`.
+            # TODO: Investigate supporting fission with PE/COFF, this should avoid this warning.
+            if ($SwiftDebugFormat -eq "dwarf") {
+              if ($UseGNUDriver) {
+                $LinkerFlags += @("-Xlinker", "/IGNORE:longsections")
+              }
+            }
           }
         }