[Sema] Downgrade an ASSERT for 6.2

hamishknight · hamishknight · commit ce273f452774 · 2025-07-02T21:30:31.000+01:00
diff --git a/lib/Sema/TypeCheckExpr.cpp b/lib/Sema/TypeCheckExpr.cpp
@@ -797,7 +797,7 @@ Expr *CallerSideDefaultArgExprRequest::evaluate(
       // simple literals.
       transaction.abort();
       (void)param->getTypeCheckedDefaultExpr();
-      ASSERT(ctx.Diags.hadAnyError());
+      CONDITIONAL_ASSERT(ctx.Diags.hadAnyError());
     }
     return new (ctx) ErrorExpr(initExpr->getSourceRange(), paramTy);
   }

Original file line number	Diff line number	Diff line change
`@@ -797,7 +797,7 @@ Expr *CallerSideDefaultArgExprRequest::evaluate(`
`797`	`797`	`// simple literals.`
`798`	`798`	`transaction.abort();`
`799`	`799`	`(void)param->getTypeCheckedDefaultExpr();`
`800`		`- ASSERT(ctx.Diags.hadAnyError());`
	`800`	`+ CONDITIONAL_ASSERT(ctx.Diags.hadAnyError());`
`801`	`801`	`}`
`802`	`802`	`return new (ctx) ErrorExpr(initExpr->getSourceRange(), paramTy);`
`803`	`803`	`}`