[CS] Remove a couple uses of recordAnyTypeVarAsPotentialHole

It's not actually clear these are necessary anymore, and in one case
it actually makes a diagnostic worse.

Author: hamishknight

lib/Sema/CSSimplify.cpp

@@ -6683,12 +6683,6 @@ bool ConstraintSystem::repairFailures(
     if (rhs->isExistentialType())
       break;
 
-    // If the types didn't line up, let's allow right-hand side
-    // of the conversion (or pattern match) to have holes. This
-    // helps when conversion if between a type and a tuple e.g.
-    // `Int` vs. `(_, _)`.
-    recordAnyTypeVarAsPotentialHole(rhs);
-
     conversionsOrFixes.push_back(CollectionElementContextualMismatch::create(
         *this, lhs, rhs, getConstraintLocator(locator)));
     break;
@@ -6782,9 +6776,6 @@ bool ConstraintSystem::repairFailures(
 
   case ConstraintLocator::TernaryBranch:
   case ConstraintLocator::SingleValueStmtResult: {
-    recordAnyTypeVarAsPotentialHole(lhs);
-    recordAnyTypeVarAsPotentialHole(rhs);
-
     if (lhs->hasPlaceholder() || rhs->hasPlaceholder())
       return true;
 
@@ -6852,8 +6843,6 @@ bool ConstraintSystem::repairFailures(
       return true;
 
     if (isMemberMatch) {
-      recordAnyTypeVarAsPotentialHole(lhs);
-      recordAnyTypeVarAsPotentialHole(rhs);
       conversionsOrFixes.push_back(AllowAssociatedValueMismatch::create(
           *this, lhs, rhs, getConstraintLocator(locator)));
       break;

validation-test/Sema/type_checker_crashers_fixed/issue-65360.swift

@@ -9,13 +9,13 @@ let _: () -> Void = {
 
 let _: () -> Void = {
   for case (0)? in [a] {}
-  // expected-error@-1 {{pattern cannot match values of type 'Any?'}}
+  // expected-error@-1 {{cannot convert sequence element type 'Any?' to expected type 'Int?'}}
   if case (0, 0) = a {}
 }
 
 let _: () -> Void = {
   for case (0)? in [a] {}
-  // expected-error@-1 {{pattern cannot match values of type 'Any?'}}
+  // expected-error@-1 {{cannot convert sequence element type 'Any?' to expected type 'Int?'}}
   for case (0, 0) in [a] {}
 }