Don't emit throw types at -gline-tables-only. (#63847)

adrian-prantl · web-flow · commit ccd22cc491c1 · 2023-02-23T00:14:32.000-06:00
* Caught by the debug-stdlib bots. rdar://105651154 * Revert "[test] disable test for simulators" This reverts commit 8a25ffa.
diff --git a/lib/IRGen/IRGenDebugInfo.cpp b/lib/IRGen/IRGenDebugInfo.cpp
@@ -2416,7 +2416,7 @@ IRGenDebugInfoImpl::emitFunction(const SILDebugScope *DS, llvm::Function *Fn,
 
   // Get the throws information.
   llvm::DITypeArray Error = nullptr;
-  if (FnTy)
+  if (FnTy && (Opts.DebugInfoLevel > IRGenDebugInfoLevel::LineTables))
     if (auto ErrorInfo = FnTy->getOptionalErrorResult()) {
       SILType SILTy = IGM.silConv.getSILType(
           *ErrorInfo, FnTy, IGM.getMaximalTypeExpansionContext());
diff --git a/test/DebugInfo/basic.swift b/test/DebugInfo/basic.swift
@@ -1,5 +1,3 @@
-// REQUIRES: OS=macosx || OS=linux-gnu || OS=windows
-// Remove the line above when rdar://105651154 is addressed.
 // A (no longer) basic test for debug info.
 // --------------------------------------------------------------------
 // Verify that we don't emit any debug info by default.

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-// REQUIRES: OS=macosx \|\| OS=linux-gnu \|\| OS=windows`
`2`		`-// Remove the line above when rdar://105651154 is addressed.`
`3`	`1`	`// A (no longer) basic test for debug info.`
`4`	`2`	`// --------------------------------------------------------------------`
`5`	`3`	`// Verify that we don't emit any debug info by default.`