[NFC] minor cleanup

(cherry picked from commit 43debc5)

Author: atrick

SwiftCompilerSources/Sources/Optimizer/Utilities/BorrowUtils.swift

@@ -425,7 +425,7 @@ enum BeginBorrowValue {
   var baseOperand: Operand? {
     switch self {
     case let .beginBorrow(beginBorrow):
-    return beginBorrow.operand
+      return beginBorrow.operand
     case let .loadBorrow(loadBorrow):
       return loadBorrow.operand
     case .beginApply, .functionArgument, .reborrow, .uncheckOwnershipConversion:

SwiftCompilerSources/Sources/Optimizer/Utilities/OptUtils.swift

@@ -456,7 +456,7 @@ extension Instruction {
     }
   }
 
-  /// Returns true if `otherInst` is in the same block and dominated by this instruction.
+  /// Returns true if `otherInst` is in the same block and is strictly dominated by this instruction.
   /// To be used as simple dominance check if both instructions are most likely located in the same block
   /// and no DominatorTree is available (like in instruction simplification).
   func dominatesInSameBlock(_ otherInst: Instruction) -> Bool {

SwiftCompilerSources/Sources/SIL/Instruction.swift

@@ -1474,7 +1474,7 @@ final public class LoadBorrowInst : SingleValueInstruction, LoadInstruction, Bor
 }
 
 final public class StoreBorrowInst : SingleValueInstruction, StoringInstruction, BorrowIntroducingInstruction {
-  var allocStack: AllocStackInst {
+  public var allocStack: AllocStackInst {
     var dest = destination
     if let mark = dest as? MarkUnresolvedNonCopyableValueInst {
       dest = mark.operand.value

SwiftCompilerSources/Sources/SIL/Utilities/AccessUtils.swift

@@ -556,10 +556,6 @@ public struct AccessBaseAndScopes {
     self.scopes = scopes
   }
 
-  public var outerAddress: Value? {
-    base.address ?? scopes.last?.address
-  }
-
   public var enclosingAccess: EnclosingAccessScope {
     return scopes.first ?? .base(base)
   }

SwiftCompilerSources/Sources/SIL/Utilities/WalkUtils.swift

@@ -39,10 +39,11 @@ public enum WalkResult {
 }
 
 extension Sequence {
+  // Walk each element until the walk aborts.
   public func walk(
-    _ predicate: (Element) throws -> WalkResult
+    _ walker: (Element) throws -> WalkResult
   ) rethrows -> WalkResult {
-    return try contains { try predicate($0) == .abortWalk } ? .abortWalk : .continueWalk
+    return try contains { try walker($0) == .abortWalk } ? .abortWalk : .continueWalk
   }
 }