Merge pull request #73467 from ahoppen/assertion-failure-completing-in-single-quote-string-literal

[Lexer] Fix an assertion failure when invoking code completion inside a single-quoted string literal

Author: ahoppen

lib/Parse/Lexer.cpp

@@ -1832,6 +1832,12 @@ void Lexer::diagnoseSingleQuoteStringLiteral(const char *TokStart,
       OutputPtr = Ptr;
       // Escape double quotes.
       replacement.append("\\\"");
+    } else if (Ptr[-1] == 0) {
+      // The string literal might contain a null byte if the code completion
+      // position is inside the string literal. Don't include the null byte in
+      // the replacement string.
+      replacement.append(OutputPtr, Ptr - 1);
+      OutputPtr = Ptr;
     }
   }
   assert(Ptr == TokEnd && Ptr[-1] == '\'');

test/SourceKit/CodeComplete/complete_in_single_quoted_string_literal.swift

@@ -0,0 +1,4 @@
+fileprivate enum BundleComponent {
+  // RUN: %sourcekitd-test -req=complete -pos=%(line + 1):25 %s -- %s
+  case swiftVersions = 's'
+}