Merge pull request #38536 from beccadax/dumpstered-imports

[NFC] Add ImportSet::dump() + fix module dumpRef

Author: beccadax

include/swift/AST/ImportCache.h

@@ -98,6 +98,8 @@ class ImportSet final :
       return {getTrailingObjects<ImportedModule>(),
               NumTopLevelImports + NumTransitiveImports};
   }
+
+  SWIFT_DEBUG_DUMP;
 };
 
 class alignas(ImportedModule) ImportCache {

lib/AST/ASTDumper.cpp

@@ -1320,9 +1320,11 @@ std::string ValueDecl::printRef() const {
 }
 
 void ValueDecl::dumpRef(raw_ostream &os) const {
-  // Print the context.
-  printContext(os, getDeclContext());
-  os << ".";
+  if (!isa<ModuleDecl>(this)) {
+    // Print the context.
+    printContext(os, getDeclContext());
+    os << ".";
+  }
 
   // Print name.
   getName().printPretty(os);

lib/AST/ImportCache.cpp

@@ -63,6 +63,24 @@ void ImportSet::Profile(
   }
 }
 
+void ImportSet::dump() const {
+  llvm::errs() << "HasHeaderImportModule: " << HasHeaderImportModule << "\n";
+
+  llvm::errs() << "TopLevelImports:";
+  for (auto import : getTopLevelImports()) {
+    llvm::errs() << "\n- ";
+    simple_display(llvm::errs(), import);
+  }
+  llvm::errs() << "\n";
+
+  llvm::errs() << "TransitiveImports:";
+  for (auto import : getTransitiveImports()) {
+    llvm::errs() << "\n- ";
+    simple_display(llvm::errs(), import);
+  }
+  llvm::errs() << "\n";
+}
+
 static void collectExports(ImportedModule next,
                            SmallVectorImpl<ImportedModule> &stack) {
   SmallVector<ImportedModule, 4> exports;