[ASTGen] Clone expanded AvailabilitySpec to set macro location

Author: rintaro

include/swift/AST/ASTBridging.h

@@ -735,6 +735,15 @@ BridgedAvailabilitySpec BridgedAvailabilitySpec_createForDomainIdentifier(
     BridgedASTContext cContext, BridgedIdentifier cName, BridgedSourceLoc cLoc,
     BridgedVersionTuple cVersion, BridgedSourceRange cVersionRange);
 
+SWIFT_NAME("BridgedAvailabilitySpec.clone(self:_:)")
+BridgedAvailabilitySpec
+BridgedAvailabilitySpec_clone(BridgedAvailabilitySpec spec,
+                              BridgedASTContext cContext);
+
+SWIFT_NAME("BridgedAvailabilitySpec.setMacroLoc(self:_:)")
+void BridgedAvailabilitySpec_setMacroLoc(BridgedAvailabilitySpec spec,
+                                         BridgedSourceLoc cLoc);
+
 SWIFT_NAME("getter:BridgedAvailabilitySpec.domainOrIdentifier(self:)")
 BridgedAvailabilityDomainOrIdentifier
 BridgedAvailabilitySpec_getDomainOrIdentifier(BridgedAvailabilitySpec spec);

lib/AST/Bridging/AvailabilityBridging.cpp

@@ -94,6 +94,17 @@ BridgedAvailabilitySpec BridgedAvailabilitySpec_createForDomainIdentifier(
       cVersion.unbridged(), cVersionRange.unbridged());
 }
 
+BridgedAvailabilitySpec
+BridgedAvailabilitySpec_clone(BridgedAvailabilitySpec spec,
+                              BridgedASTContext cContext) {
+  return spec.unbridged()->clone(cContext.unbridged());
+}
+
+void BridgedAvailabilitySpec_setMacroLoc(BridgedAvailabilitySpec spec,
+                                         BridgedSourceLoc cLoc) {
+  spec.unbridged()->setMacroLoc(cLoc.unbridged());
+}
+
 BridgedAvailabilityDomainOrIdentifier
 BridgedAvailabilitySpec_getDomainOrIdentifier(BridgedAvailabilitySpec spec) {
   return spec.unbridged()->getDomainOrIdentifier();

lib/ASTGen/Sources/ASTGen/Availability.swift

@@ -309,10 +309,15 @@ extension ASTGenVisitor {
           version: version?.bridged ?? BridgedVersionTuple()
         )
         if !expanded.isEmpty {
+          let macroLoc = self.generateSourceLoc(domainNode)
           expanded.withElements(ofType: UnsafeRawPointer.self) { buffer in
             for ptr in buffer {
-              // TODO: Clone and spec.setMacroLoc().
-              result.append(BridgedAvailabilitySpec(raw: UnsafeMutableRawPointer(mutating: ptr)))
+              // Make a copy of the specs to add the macro source location
+              // for the diagnostic about the use of macros in inlinable code.
+              let spec = BridgedAvailabilitySpec(raw: UnsafeMutableRawPointer(mutating: ptr))
+                .clone(self.ctx)
+              spec.setMacroLoc(macroLoc)
+              result.append(spec)
             }
           }
           return
@@ -325,6 +330,8 @@ extension ASTGenVisitor {
         // TODO: Diagnostics.
         fatalError("expected version")
       }
+      // FIXME: Wasting ASTContext memory.
+      // 'AvailabilitySpec' is 'ASTAllocated' but created spec is ephemeral in context of `@available` attributes.
       let spec = BridgedAvailabilitySpec.createForDomainIdentifier(
         self.ctx,
         name: platform.identifier,