Sema: Use clearer param name in getPublicModuleName

Use onlyIfImported instead of mustBeVisible.

Author: xymus

include/swift/AST/Module.h

@@ -511,11 +511,11 @@ class ModuleDecl
   /// This always returns a valid name as it defaults to the module name if
   /// no public module name is set.
   ///
-  /// If `mustBeVisible`, return the normal module name when the module
+  /// If `onlyIfImported`, return the normal module name when the module
   /// corresponding to the public module name isn't imported. Users working
   /// in between both modules will then see the normal module name,
   /// this may be more useful for diagnostics at that level.
-  Identifier getPublicModuleName(bool mustBeVisible) const;
+  Identifier getPublicModuleName(bool onlyIfImported) const;
 
   void setPublicModuleName(Identifier name) {
     PublicModuleName = name;

lib/AST/DiagnosticEngine.cpp

@@ -800,7 +800,7 @@ static void formatDiagnosticArgument(StringRef Modifier,
     DeclName name;
     if (includeName) {
       if (auto MD = dyn_cast<ModuleDecl>(D))
-        name = MD->getPublicModuleName(/*mustBeVisible=*/true);
+        name = MD->getPublicModuleName(/*onlyIfImported=*/true);
       else if (auto VD = dyn_cast<ValueDecl>(D))
         name = VD->getName();
       else if (auto PGD = dyn_cast<PrecedenceGroupDecl>(D))
@@ -1374,7 +1374,7 @@ DiagnosticEngine::diagnosticInfoForDiagnostic(const Diagnostic &diagnostic) {
           SmallVector<StringRef, 4> nameComponents;
           while (dc) {
             auto publicName = cast<ModuleDecl>(dc)->
-                                getPublicModuleName(/*mustBeVisible*/true);
+                                getPublicModuleName(/*onlyIfImported*/true);
             nameComponents.push_back(publicName.str());
             dc = dc->getParent();
           }

lib/AST/Module.cpp

@@ -1922,9 +1922,9 @@ ImportedModule::removeDuplicates(SmallVectorImpl<ImportedModule> &imports) {
   imports.erase(last, imports.end());
 }
 
-Identifier ModuleDecl::getPublicModuleName(bool mustBeVisible) const {
+Identifier ModuleDecl::getPublicModuleName(bool onlyIfImported) const {
   if (!PublicModuleName.empty()) {
-    if (!mustBeVisible)
+    if (!onlyIfImported)
       return PublicModuleName;
 
     bool publicModuleIsImported =

lib/Serialization/Serialization.cpp

@@ -1127,7 +1127,7 @@ void Serializer::writeHeader() {
       }
 
       Identifier publicModuleName =
-        M->getPublicModuleName(/*mustBeVisible=*/false);
+        M->getPublicModuleName(/*onlyIfImported=*/false);
       if (publicModuleName != M->getName()) {
         options_block::PublicModuleNameLayout PublicModuleName(Out);
         PublicModuleName.emit(ScratchRecord, publicModuleName.str());