Merge pull request #42107 from eeckstein/fix-mem-behvior

MemAccessUtils: handle the case of `enum` with no operand in findOwnershipReferenceAggregate

Author: eeckstein

lib/SIL/Utils/MemAccessUtils.cpp

@@ -912,7 +912,13 @@ SILValue swift::findOwnershipReferenceAggregate(SILValue ref) {
         || isa<OwnershipForwardingConversionInst>(root)
         || isa<OwnershipForwardingSelectEnumInstBase>(root)
         || isa<OwnershipForwardingMultipleValueInstruction>(root)) {
-      root = root->getDefiningInstruction()->getOperand(0);
+      SILInstruction *inst = root->getDefiningInstruction();
+
+      // The `enum` instruction can have no operand.
+      if (inst->getNumOperands() == 0)
+        return root;
+
+      root = inst->getOperand(0);
       continue;
     }
     if (auto *arg = dyn_cast<SILArgument>(root)) {

test/SILOptimizer/mem-behavior.sil

@@ -699,6 +699,28 @@ bb4:
   return %5 : $Int32
 }
 
+// CHECK-LABEL: @dontCrashWithOptionalNone
+// CHECK:       PAIR #0.
+// CHECK-NEXT:      %6 = apply %5() : $@convention(thin) () -> ()
+// CHECK-NEXT:      %4 = ref_element_addr [immutable] %3 : $X, #X.a
+// CHECK-NEXT:   r=1,w=1
+sil @dontCrashWithOptionalNone : $@convention(thin) () -> () {
+bb0:
+  %26 = enum $Optional<X>, #Optional.none!enumelt
+  switch_enum %26 : $Optional<X>, case #Optional.none!enumelt: bb1, case #Optional.some!enumelt: bb2
+bb1:
+  br bb3
+bb2:
+  %68 = unchecked_enum_data %26 : $Optional<X>, #Optional.some!enumelt
+  %1 = ref_element_addr [immutable] %68 : $X, #X.a
+  %5 = function_ref @nouser_func : $@convention(thin) () -> ()
+  %6 = apply %5() : $@convention(thin) () -> ()
+  br bb3
+bb3:
+  %r = tuple ()
+  return %r : $()
+}
+
 // CHECK-LABEL: @testLoadTake
 // CHECK:      PAIR #0.
 // CHECK-NEXT:   %2 = load [take] %0 : $*C