[move-only] Refactor both implementations to use the same diagnostic infrastructure.

This let me clean up the parts of the address infrastructure that rely on the
object checker.

Author: gottesmm

include/swift/SILOptimizer/Utils/InstructionDeleter.h

@@ -126,6 +126,10 @@ class InstructionDeleter {
 
   InstModCallbacks &getCallbacks() { return callbacks; }
 
+  void setCallbacks(const InstModCallbacks &newCallbacks) {
+    callbacks = newCallbacks;
+  }
+
   bool hadCallbackInvocation() const {
     return const_cast<InstructionDeleter *>(this)
         ->getCallbacks()

lib/SILOptimizer/Mandatory/CMakeLists.txt

@@ -24,6 +24,7 @@ target_sources(swiftSILOptimizer PRIVATE
   MovedAsyncVarDebugInfoPropagator.cpp
   MoveKillsCopyableAddressesChecker.cpp
   MoveKillsCopyableValuesChecker.cpp
+  MoveOnlyDiagnostics.cpp
   MoveOnlyObjectChecker.cpp
   MoveOnlyAddressChecker.cpp
   MoveOnlyDeinitInsertion.cpp