Verify switch_value has int operands only

Author: meg-gupta

docs/SIL.rst

@@ -8401,7 +8401,7 @@ switch_value
   // FIXME: All destination labels currently must take no arguments
 
 Conditionally branches to one of several destination basic blocks based on a
-value of builtin integer or function type. If the operand value matches one of the ``case``
+value of builtin integer. If the operand value matches one of the ``case``
 values of the instruction, control is transferred to the corresponding basic
 block. If there is a ``default`` basic block, control is transferred to it if
 the value does not match any of the ``case`` values. It is undefined behavior

lib/SIL/Verifier/SILVerifier.cpp

@@ -5227,9 +5227,8 @@ class SILVerifier : public SILVerifierBase<SILVerifier> {
   void checkSwitchValueInst(SwitchValueInst *SVI) {
     // TODO: Type should be either integer or function
     auto Ty = SVI->getOperand()->getType();
-    require(Ty.is<BuiltinIntegerType>() || Ty.is<SILFunctionType>(),
-            "switch_value operand should be either of an integer "
-            "or function type");
+    require(Ty.is<BuiltinIntegerType>(),
+            "switch_value operand should be an integer");
 
     auto ult = [](const SILValue &a, const SILValue &b) { 
       return a == b || a < b; 

test/SIL/Parser/basic.sil

@@ -973,51 +973,6 @@ bb3:
   return %t : $()
 }
 
-// CHECK-LABEL: sil @test_switch_value : $@convention(thin) (Builtin.Word) -> ()
-sil @test_switch_value : $@convention(thin) (Builtin.Word) -> () {
-bb0(%0 : $Builtin.Word):
-  // CHECK: switch_value %{{.*}} : $Builtin.Word, case %1: bb1, case %2: bb2
-  %1 = integer_literal $Builtin.Word, 1
-  %2 = integer_literal $Builtin.Word, 2
-  switch_value %0 : $Builtin.Word, case %1: bb1, case %2: bb2
-
-bb1:
-  %7 = function_ref @_T6switch1aFT_T_ : $@convention(thin) () -> () // CHECK: function_ref
-  %8 = apply %7() : $@convention(thin) () -> ()
-  br bb3
-
-bb2:
-  %12 = function_ref @_T6switch1bFT_T_ : $@convention(thin) () -> () // CHECK: function_ref
-  %13 = apply %12() : $@convention(thin) () -> ()
-  br bb3
-
-bb3:
-  // CHECK: [[FUNC1:%.*]] = function_ref @_T6switch1aFT_T_
-  // CHECK: [[FUNC2:%.*]] = function_ref @_T6switch1bFT_T_
-  // CHECK: switch_value %{{.*}} : $@convention(thin) () -> (), case [[FUNC1]]: bb4, case [[FUNC2]]: bb5
-  %20 = function_ref @_T6switch1bFT_T_ : $@convention(thin) () -> ()
-  %21 = function_ref @_T6switch1aFT_T_ : $@convention(thin) () -> ()
-  %22 = function_ref @_T6switch1bFT_T_ : $@convention(thin) () -> ()
-  switch_value %20 : $@convention(thin) () -> (), case %21: bb4, case %22: bb5
-
-bb4:
-  // CHECK: function_ref
-  %37 = function_ref @_T6switch1aFT_T_ : $@convention(thin) () -> ()
-  %38 = apply %37() : $@convention(thin) () -> ()
-  br bb6
-
-bb5:
-  // CHECK: function_ref
-  %42 = function_ref @_T6switch1bFT_T_ : $@convention(thin) () -> ()
-  %43 = apply %42() : $@convention(thin) () -> ()
-  br bb6
-
-bb6:
-  %18 = tuple ()
-  // CHECK: return
-  return %18 : $()
-}
-
 class ConcreteClass : ClassP {
 }
 struct Spoon : Bendable {

test/SIL/Parser/undef.sil

@@ -287,17 +287,6 @@ bb2:
   return undef : $()
 }
 
-sil @switch_value_test : $() -> () {
-bb0:
-  // CHECK: switch_value undef : $Builtin.Int1, case undef: bb1
-  switch_value undef : $Builtin.Int1, case undef: bb1
-bb1:
-  // CHECK: switch_value undef : $() -> (), case undef: bb2
-  switch_value undef : $() -> (), case undef: bb2
-bb2:
-  return undef : $()
-}
-
 sil @switch_enum_test : $() -> () {
 bb0:
   // CHECK: switch_enum undef : $E, case #E.Case!enumelt: bb1, default bb2