Merge pull request #69559 from tshortli/module-interface-lazy-typecheck-has-missing-inits

AST: Make HasMissingDesignatedInitializersRequest more consistent

Author: tshortli

lib/AST/NameLookupRequests.cpp

@@ -10,16 +10,17 @@
 //
 //===----------------------------------------------------------------------===//
 
-#include "swift/AST/NameLookup.h"
 #include "swift/AST/NameLookupRequests.h"
 #include "swift/AST/ASTContext.h"
 #include "swift/AST/Decl.h"
+#include "swift/AST/Evaluator.h"
 #include "swift/AST/GenericParamList.h"
+#include "swift/AST/Module.h"
+#include "swift/AST/NameLookup.h"
 #include "swift/AST/PotentialMacroExpansions.h"
 #include "swift/AST/ProtocolConformance.h"
-#include "swift/AST/Evaluator.h"
-#include "swift/AST/Module.h"
 #include "swift/AST/SourceFile.h"
+#include "swift/AST/TypeCheckRequests.h"
 #include "swift/ClangImporter/ClangImporterRequests.h"
 #include "swift/Subsystems.h"
 
@@ -156,6 +157,13 @@ HasMissingDesignatedInitializersRequest::evaluate(Evaluator &evaluator,
   if (!scope.isPublic())
     return false;
 
+  // Make sure any implicit constructors are synthesized.
+  (void)evaluateOrDefault(
+      evaluator,
+      ResolveImplicitMemberRequest{subject,
+                                   ImplicitMemberAction::ResolveImplicitInit},
+      {});
+
   auto constructors = subject->lookupDirect(DeclBaseName::createConstructor());
   return llvm::any_of(constructors, [&](ValueDecl *decl) {
     auto init = cast<ConstructorDecl>(decl);

test/Inputs/lazy_typecheck.swift

@@ -206,6 +206,8 @@ public class PublicClass {
 
 public class PublicDerivedClass: PublicClass {}
 
+open class PublicClassSynthesizedDesignatedInit {}
+
 class InternalClass: NoTypecheckProto {
   init(x: NoTypecheck) {}
 }

test/Inputs/lazy_typecheck_client.swift

@@ -43,7 +43,7 @@ func testPublicStruct() {
   PublicStruct.activeMethod()
 }
 
-func testPublicClass() {
+func testPublicClasses() {
   let c = PublicClass(x: 2)
   let _: Int = c.publicMethod()
   let _: Int = c.publicProperty
@@ -55,6 +55,11 @@ func testPublicClass() {
   let _: Int = d.publicProperty
   let _: String = d.publicPropertyInferredType
   PublicDerivedClass.publicClassMethod()
+
+  class DerivedFromPublicClassSynthesizedDesignatedInit: PublicClassSynthesizedDesignatedInit {
+    init() {}
+  }
+  let _ = DerivedFromPublicClassSynthesizedDesignatedInit()
 }
 
 func testPublicEnum(_ e: PublicEnum) {