Remove the old SideEffectAnalysis

Author: eeckstein

include/swift/SILOptimizer/Analysis/Analysis.def

@@ -44,7 +44,6 @@ SIL_ANALYSIS(PostDominance)
 SIL_ANALYSIS(PostOrder)
 SIL_ANALYSIS(ProtocolConformance)
 SIL_ANALYSIS(RCIdentity)
-SIL_ANALYSIS(SideEffect)
 SIL_ANALYSIS(TypeExpansion)
 SIL_ANALYSIS(PassManagerVerifier)
 SIL_ANALYSIS(DeadEndBlocks)