Merge pull request #72970 from kubamracek/embedded-assert-prints-only-in-release

kubamracek · web-flow · commit c0e8f7eed8f2 · 2024-04-11T02:00:52.000-07:00
[embedded] Conditionalize assert printing to debug assert config
diff --git a/stdlib/public/core/AssertCommon.swift b/stdlib/public/core/AssertCommon.swift
@@ -111,8 +111,10 @@ internal func _assertionFailure(
     }
   }
 #else
-  _embeddedReportFatalErrorInFile(prefix: prefix, message: message, file: file,
-    line: line)
+  if _isDebugAssertConfiguration() {
+    _embeddedReportFatalErrorInFile(prefix: prefix, message: message,
+      file: file, line: line)
+  }
 #endif
   Builtin.int_trap()
 }
@@ -186,7 +188,9 @@ internal func _assertionFailure(
   _ prefix: StaticString, _ message: StaticString,
   flags: UInt32
 ) -> Never {
-  _embeddedReportFatalError(prefix: prefix, message: message)
+  if _isDebugAssertConfiguration() {
+    _embeddedReportFatalError(prefix: prefix, message: message)
+  }
 
   Builtin.int_trap()
 }

Original file line number	Diff line number	Diff line change
`@@ -111,8 +111,10 @@ internal func _assertionFailure(`
`111`	`111`	`}`
`112`	`112`	`}`
`113`	`113`	`#else`
`114`		`- _embeddedReportFatalErrorInFile(prefix: prefix, message: message, file: file,`
`115`		`- line: line)`
	`114`	`+ if _isDebugAssertConfiguration() {`
	`115`	`+ _embeddedReportFatalErrorInFile(prefix: prefix, message: message,`
	`116`	`+ file: file, line: line)`
	`117`	`+ }`
`116`	`118`	`#endif`
`117`	`119`	`Builtin.int_trap()`
`118`	`120`	`}`
`@@ -186,7 +188,9 @@ internal func _assertionFailure(`
`186`	`188`	`_ prefix: StaticString, _ message: StaticString,`
`187`	`189`	`flags: UInt32`
`188`	`190`	`) -> Never {`
`189`		`- _embeddedReportFatalError(prefix: prefix, message: message)`
	`191`	`+ if _isDebugAssertConfiguration() {`
	`192`	`+ _embeddedReportFatalError(prefix: prefix, message: message)`
	`193`	`+ }`
`190`	`194`
`191`	`195`	`Builtin.int_trap()`
`192`	`196`	`}`