Merge pull request #65399 from ahoppen/ahoppen/rename-macro-definition

[Rename] Also syntactically rename a macro’s definition

Author: ahoppen

include/swift/AST/ASTWalker.h

@@ -591,6 +591,10 @@ class ASTWalker {
   /// TODO: Consider changing this to false by default.
   virtual bool shouldWalkSerializedTopLevelInternalDecls() { return true; }
 
+  /// Whether to walk into the definition of a \c MacroDecl if it hasn't been
+  /// type-checked yet.
+  virtual bool shouldWalkIntoUncheckedMacroDefinitions() { return false; }
+
   /// walkToParameterListPre - This method is called when first visiting a
   /// ParameterList, before walking into its parameters.
   ///

include/swift/IDE/Utils.h

@@ -379,6 +379,7 @@ class NameMatcher: public ASTWalker {
   PreWalkAction walkToTypeReprPre(TypeRepr *T) override;
   PreWalkResult<Pattern *> walkToPatternPre(Pattern *P) override;
   bool shouldWalkIntoGenericParams() override { return true; }
+  bool shouldWalkIntoUncheckedMacroDefinitions() override { return true; }
 
   PreWalkResult<ArgumentList *>
   walkToArgumentListPre(ArgumentList *ArgList) override;

lib/AST/ASTWalker.cpp

@@ -425,7 +425,8 @@ class Traversal : public ASTVisitor<Traversal, Expr*, Stmt*,
     if (auto def = MD->definition) {
       // Don't walk into unchecked definitions.
       if (auto expansion = dyn_cast<MacroExpansionExpr>(def)) {
-        if (!expansion->getType().isNull()) {
+        if (!expansion->getType().isNull() ||
+            Walker.shouldWalkIntoUncheckedMacroDefinitions()) {
           if (auto newDef = doIt(def))
             MD->definition = newDef;
           else

test/refactoring/SyntacticRename/macro-definition.swift

@@ -0,0 +1,11 @@
+// RUN: %empty-directory(%t.ranges)
+// RUN: %refactor -find-rename-ranges -source-filename %s -pos="test" -is-function-like -old-name "StringifyMacro" | %FileCheck %s
+
+// CHECK: struct /*test:def*/<base>StringifyMacro</base> {}
+// CHECK: @freestanding(expression)
+// CHECK: macro stringify<T>(_ value: T) -> (T, String) = #externalMacro(module: "MyMacroMacros", type: "/*test:ref*/<base>StringifyMacro</base>")
+
+struct /*test:def*/StringifyMacro {}
+
+@freestanding(expression)
+macro stringify<T>(_ value: T) -> (T, String) = #externalMacro(module: "MyMacroMacros", type: "/*test:ref*/StringifyMacro")