[NFC] forEachMissingConformance doesn't use module

Author: kavon

include/swift/AST/ProtocolConformanceRef.h

@@ -128,7 +128,7 @@ class ProtocolConformanceRef {
   /// Determine whether this conformance (or a conformance it depends on)
   /// involves a "missing" conformance anywhere. Such conformances
   /// cannot be depended on to always exist.
-  bool hasMissingConformance(ModuleDecl *module) const;
+  bool hasMissingConformance() const;
 
   /// Enumerate the missing conformances in this conformance.
   ///
@@ -140,7 +140,6 @@ class ProtocolConformanceRef {
   /// \returns \c true if any invocation of \c fn returned true,
   /// \c false otherwise.
   bool forEachMissingConformance(
-      ModuleDecl *module,
       llvm::function_ref<bool(BuiltinProtocolConformance *missing)> fn) const;
 
   using OpaqueValue = void*;

lib/AST/Module.cpp

@@ -1696,7 +1696,7 @@ ProtocolConformanceRef ModuleDecl::lookupConformance(Type type,
   // replace the result with an "invalid" result.
   if (!allowMissing &&
       shouldCreateMissingConformances(type, protocol) &&
-      result.hasMissingConformance(this))
+      result.hasMissingConformance())
     return ProtocolConformanceRef::forInvalid();
 
   return result;

lib/AST/ProtocolConformanceRef.cpp

@@ -319,22 +319,21 @@ bool ProtocolConformanceRef::hasUnavailableConformance() const {
   return false;
 }
 
-bool ProtocolConformanceRef::hasMissingConformance(ModuleDecl *module) const {
-  return forEachMissingConformance(module,
+bool ProtocolConformanceRef::hasMissingConformance() const {
+  return forEachMissingConformance(
       [](BuiltinProtocolConformance *builtin) {
         return true;
       });
 }
 
 bool ProtocolConformanceRef::forEachMissingConformance(
-    ModuleDecl *module,
     llvm::function_ref<bool(BuiltinProtocolConformance *missing)> fn) const {
   if (isInvalid() || isAbstract())
     return false;
 
   if (isPack()) {
     for (auto conformance : getPack()->getPatternConformances()) {
-      if (conformance.forEachMissingConformance(module, fn))
+      if (conformance.forEachMissingConformance(fn))
         return true;
     }
 
@@ -352,7 +351,7 @@ bool ProtocolConformanceRef::forEachMissingConformance(
   // Check conformances that are part of this conformance.
   auto subMap = concreteConf->getSubstitutionMap();
   for (auto conformance : subMap.getConformances()) {
-    if (conformance.forEachMissingConformance(module, fn))
+    if (conformance.forEachMissingConformance(fn))
       return true;
   }
 

lib/Sema/CSSimplify.cpp

@@ -8414,8 +8414,7 @@ ConstraintSystem::SolutionKind ConstraintSystem::simplifyConformsToConstraint(
       increaseScore(SK_Unavailable, locator);
 
     unsigned numMissing = 0;
-    conformance.forEachMissingConformance(DC->getParentModule(),
-                                          [&numMissing](auto *missing) {
+    conformance.forEachMissingConformance([&numMissing](auto *missing) {
                                             ++numMissing;
                                             return false;
                                           });

lib/Sema/ConstraintSystem.cpp

@@ -7672,7 +7672,7 @@ ConstraintSystem::inferKeyPathLiteralCapability(KeyPathExpr *keyPath) {
             auto conformance = lookupConformance(argTy, sendable);
             isSendable &=
                 bool(conformance) &&
-                !conformance.hasMissingConformance(DC->getParentModule());
+                !conformance.hasMissingConformance();
           }
         }
       }

lib/Sema/TypeCheckConcurrency.cpp

@@ -701,7 +701,7 @@ bool swift::isSendableType(ModuleDecl *module, Type type) {
     return false;
 
   // Look for missing Sendable conformances.
-  return !conformance.forEachMissingConformance(module,
+  return !conformance.forEachMissingConformance(
       [](BuiltinProtocolConformance *missing) {
         return missing->getProtocol()->isSpecificProtocol(
             KnownProtocolKind::Sendable);
@@ -1082,7 +1082,7 @@ bool swift::diagnoseNonSendableTypes(
 
   // Walk the conformance, diagnosing any missing Sendable conformances.
   bool anyMissing = false;
-  conformance.forEachMissingConformance(module,
+  conformance.forEachMissingConformance(
       [&](BuiltinProtocolConformance *missing) {
         if (diagnoseSingleNonSendableType(
                 missing->getType(), fromContext,
@@ -1281,7 +1281,7 @@ namespace {
           return true;
 
         // Look for missing Sendable conformances.
-        return conformance.forEachMissingConformance(module,
+        return conformance.forEachMissingConformance(
             [&](BuiltinProtocolConformance *missing) {
               // For anything other than Sendable, fail.
               if (missing->getProtocol() != sendableProto)