PR feedback

Author: andrurogerz

tools/swift-inspect/Sources/SwiftInspectLinux/SymbolCache.swift

@@ -37,9 +37,7 @@ public class SymbolCache {
     self.linkMap = try LinkMap(for: process)
     var symbolLookup: SymbolLookup = [:]
     for linkMapEntry in linkMap.entries {
-      guard FileManager.default.fileExists(atPath: linkMapEntry.moduleName) else { continue }
-
-      let elfFile = try ElfFile(filePath: linkMapEntry.moduleName)
+      guard let elfFile = try? ElfFile(filePath: linkMapEntry.moduleName) else { continue }
       let symbolMap = try elfFile.loadSymbols(baseAddress: linkMapEntry.baseAddress)
       symbolLookup[linkMapEntry.moduleName] = symbolMap
     }

tools/swift-inspect/Sources/swift-inspect/LinuxRemoteProcess.swift

@@ -112,7 +112,7 @@
         self.symbolCache = try SwiftInspectLinux.SymbolCache(for: process)
         self.memoryMap = try SwiftInspectLinux.MemoryMap(for: processId)
       } catch {
-        fputs("failed initialization for process \(processId): \(error)\n", stderr)
+        fatalError("failed initialization for process \(processId): \(error)")
         return nil
       }
 
@@ -152,7 +152,7 @@
     }
 
     internal func iterateHeap(_ body: (swift_addr_t, UInt64) -> Void) {
-      fputs("heap iteration is not supported on Linux\n", stderr)
+      fatalError("heap iteration is not supported on Linux")
     }
   }
 #endif  // os(Linux)