Test predictable memopt mark_dependence semantics.

Unit tests for mark_dependence support. Required to fix unsafeAddress.

Author: atrick

lib/SILOptimizer/Mandatory/PredictableMemOpt.cpp

@@ -485,12 +485,18 @@ struct AvailableValueDataflowFixup: AvailableValueFixup {
 
   // Verify ownership of promoted instructions in asserts builds or when
   // -sil-verify-all is set.
+  //
+  // Clears insertedInsts.
   void verifyOwnership(DeadEndBlocks &deBlocks);
 
-  /// Fix ownership of inserted instructions and delete dead instructions.
+  // Fix ownership of inserted instructions and delete dead instructions.
+  //
+  // Clears insertedInsts.
   void fixupOwnership(InstructionDeleter &deleter,
                       DeadEndBlocks &deBlocks);
 
+  // Deletes all insertedInsts without fixing ownership.
+  // Clears insertedInsts.
   void deleteInsertedInsts(InstructionDeleter &deleter);
 };
 
@@ -532,6 +538,7 @@ void AvailableValueDataflowFixup::verifyOwnership(DeadEndBlocks &deBlocks) {
       result.verifyOwnership(&deBlocks);
     }
   }
+  insertedInsts.clear();
 }
 
 // In OptimizationMode::PreserveAlloc, delete any inserted instructions that are

test/SILOptimizer/constant_evaluable_subset_test.swift

@@ -14,6 +14,6 @@
 // especially performance inlining as it inlines functions such as String.+=
 // that the evaluator has special knowledge about.
 //
-// RUN: not %target-sil-opt -opt-mode=speed -silgen-cleanup -diagnose-invalid-escaping-captures -diagnose-static-exclusivity -capture-promotion -access-enforcement-selection -allocbox-to-stack -noreturn-folding -definite-init -raw-sil-inst-lowering -closure-lifetime-fixup -semantic-arc-opts -ownership-model-eliminator -mandatory-inlining -predictable-memaccess-opts -os-log-optimization -diagnostic-constant-propagation -predictable-deadalloc-elim -mandatory-arc-opts -diagnose-unreachable -diagnose-infinite-recursion -yield-once-check -dataflow-diagnostics -split-non-cond_br-critical-edges -constexpr-limit 3000 -test-constant-evaluable-subset %t/constant_evaluable_subset_test_silgen.sil > /dev/null 2> %t/error-output-mandatory
+// RUN: not %target-sil-opt -opt-mode=speed -silgen-cleanup -diagnose-invalid-escaping-captures -diagnose-static-exclusivity -capture-promotion -access-enforcement-selection -allocbox-to-stack -noreturn-folding -definite-init -raw-sil-inst-lowering -closure-lifetime-fixup -semantic-arc-opts -mandatory-inlining -predictable-memaccess-opts -os-log-optimization -diagnostic-constant-propagation -predictable-deadalloc-elim -mandatory-arc-opts -diagnose-unreachable -diagnose-infinite-recursion -yield-once-check -dataflow-diagnostics -split-non-cond_br-critical-edges -constexpr-limit 3000 -test-constant-evaluable-subset %t/constant_evaluable_subset_test_silgen.sil > /dev/null 2> %t/error-output-mandatory
 //
 // RUN: %FileCheck %S/Inputs/constant_evaluable.swift < %t/error-output-mandatory

test/SILOptimizer/lifetime_dependence/lifetime_dependence_scope_fixup.swift

@@ -156,11 +156,12 @@ func test6(_ a: Array<Int>) {
 
 // CHECK-LABEL: sil hidden @$s31lifetime_dependence_scope_fixup5test7yySWF : $@convention(thin) (UnsafeRawBufferPointer) -> () {
 // CHECK:   [[CONT:%.*]] = alloc_stack [var_decl] $View
+// function_ref View.init(_:_:)
+// CHECK:   [[VIEW1:%.*]] = apply %{{.*}}(%0, %{{.*}}, %{{.*}}) : $@convention(method) (UnsafeRawBufferPointer, Int, @thin View.Type) -> @lifetime(borrow 0) @owned View // users: %14, %9, %12, %8
 // CHECK:   [[BA:%.*]] = begin_access [read] [static] [[CONT]] : $*View
-// CHECK:   [[LD:%.*]] = load [[BA]] : $*View
 // CHECK:   [[FUNC:%.*]] = function_ref @$s31lifetime_dependence_scope_fixup16getBorrowingViewyAA0G0VADF : $@convention(thin) (@guaranteed View) -> @lifetime(borrow 0) @owned View
-// CHECK:   [[VIEW:%.*]] = apply [[FUNC]]([[LD]]) : $@convention(thin) (@guaranteed View) -> @lifetime(borrow 0) @owned View
-// CHECK:   [[MDI:%.*]] = mark_dependence [nonescaping] [[VIEW]] : $View on [[BA]] : $*View
+// CHECK:   [[VIEW2:%.*]] = apply [[FUNC]]([[VIEW1]]) : $@convention(thin) (@guaranteed View) -> @lifetime(borrow 0) @owned View
+// CHECK:   [[MDI:%.*]] = mark_dependence [nonescaping] [[VIEW2]] : $View on [[BA]] : $*View
 // CHECK:   [[USE:%.*]] = function_ref @$s31lifetime_dependence_scope_fixup3useyyAA4ViewVF : $@convention(thin) (@guaranteed View) -> ()
 // CHECK:   apply [[USE]]([[MDI]]) : $@convention(thin) (@guaranteed View) -> ()
 // CHECK:   release_value [[MDI]] : $View