Merge pull request #72600 from nate-chandler/rdar125443922

[BitwiseCopyable] Loosen validation assertion.

Author: nate-chandler

lib/SIL/IR/TypeLowering.cpp

@@ -3203,11 +3203,13 @@ void TypeConverter::verifyTrivialLowering(const TypeLowering &lowering,
     }
   }
 
-  if (!lowering.isTrivial() && conformance) {
+  if (!lowering.isTrivial() && conformance &&
+      !conformance.hasUnavailableConformance()) {
     // A non-trivial type can have a conformance in a few cases:
-    // (1) contains a conforming archetype
+    // (1) containing or being a conforming archetype
     // (2) is resilient with minimal expansion
     // (3) containing or being ~Escapable
+    // (4) containing or being an opaque archetype
     bool hasNoConformingArchetypeNode = visitAggregateLeaves(
         origType, substType, forExpansion,
         /*isLeaf=*/
@@ -3256,6 +3258,11 @@ void TypeConverter::verifyTrivialLowering(const TypeLowering &lowering,
           if (origTy.isTypeParameter())
             return false;
 
+          // An opaque archetype may conform but be non-trivial (case (4)).
+          if (isa<OpaqueTypeArchetypeType>(ty)) {
+            return false;
+          }
+
           return true;
         });
     if (hasNoConformingArchetypeNode) {

test/SILGen/bitwise_copyable.swift

@@ -47,3 +47,15 @@ public enum E : _BitwiseCopyable {
 func take<T : _BitwiseCopyable>(_ t: T) {}
 
 func pass(_ e: E) { take(e) }
+
+func opacify() -> some _BitwiseCopyable {
+    return Int()
+}
+
+struct NeverGoingToBeBitwiseCopyable {
+  var a: AnyObject
+}
+
+@available(*, unavailable)
+extension NeverGoingToBeBitwiseCopyable : _BitwiseCopyable {
+}