Merge pull request #80094 from swiftlang/susmonteiro/destructor-missing-dbg-info

[cxx-interop] Disable debug info in synthesized C++ methods

Author: susmonteiro

lib/ClangImporter/SwiftDeclSynthesizer.cpp

@@ -2106,6 +2106,7 @@ clang::CXXMethodDecl *SwiftDeclSynthesizer::synthesizeCXXForwardingMethod(
   newMethod->setImplicit();
   newMethod->setImplicitlyInline();
   newMethod->setAccess(clang::AccessSpecifier::AS_public);
+  newMethod->addAttr(clang::NoDebugAttr::CreateImplicit(clangCtx));
   if (method->hasAttr<clang::CFReturnsRetainedAttr>()) {
     // Return an FRT field at +1 if the base method also follows this
     // convention.

test/Interop/Cxx/class/inheritance/Inputs/virtual-methods.h

@@ -50,6 +50,10 @@ struct DerivedFromCallsPureMethod : CallsPureMethod {
 
 struct DerivedFromDerivedFromCallsPureMethod : DerivedFromCallsPureMethod {};
 
+struct HasDestructor {
+  ~HasDestructor() {}
+};
+
 // MARK: Reference Types:
 
 #define IMMORTAL_FRT                                                           \
@@ -76,6 +80,11 @@ struct IMMORTAL_FRT DerivedFromImmortal : public Immortal {
   static DerivedFromImmortal *_Nonnull create() { return new DerivedFromImmortal(); }
 };
 
+struct IMMORTAL_FRT Immortal2 {
+public:
+  virtual void virtualMethod(HasDestructor) = 0;
+};
+
 inline const ImmortalBase *_Nonnull castToImmortalBase(
     const Immortal *_Nonnull immortal) {
   return static_cast<const ImmortalBase *>(immortal);

test/Interop/Cxx/class/inheritance/virtual-methods.swift

@@ -1,6 +1,7 @@
 // RUN: %target-run-simple-swift(-I %S/Inputs -cxx-interoperability-mode=swift-5.9)
 // RUN: %target-run-simple-swift(-I %S/Inputs -cxx-interoperability-mode=swift-6)
 // RUN: %target-run-simple-swift(-I %S/Inputs -cxx-interoperability-mode=upcoming-swift)
+// RUN: %target-run-simple-swift(-g -I %S/Inputs -cxx-interoperability-mode=default)
 
 // REQUIRES: executable_test
 
@@ -53,4 +54,14 @@ if #available(SwiftStdlib 5.8, *) {
   }
 }
 
+#if !os(Windows) 
+// FIXME in Windows, non-trivial C++ class with trivial ABI is not yet available in Swift
+VirtualMethodsTestSuite.test("C++ virtual method with complex parameter") {
+  @available(macOS 13.3, *)
+  func f(simpleClass: HasDestructor, immortalClass: Immortal2) {
+    immortalClass.virtualMethod(simpleClass)
+  }
+}
+#endif
+
 runAllTests()