Merge pull request #71261 from xedin/introduce-thunks-for-runtime-check-func-refs

[Sema/SILGen] DynamicActorIsolation: Implement dynamic actor isolation checks for unsafe APIs

Author: xedin

include/swift/AST/Decl.h

@@ -2734,6 +2734,10 @@ class ValueDecl : public Decl {
   }
 
 public:
+  /// Find the import that makes the given declaration available.
+  llvm::Optional<AttributedImport<ImportedModule>>
+  findImport(const DeclContext *fromDC);
+
   /// Return true if this protocol member is a protocol requirement.
   ///
   /// Asserts if this is not a member of a protocol.

include/swift/AST/DiagnosticsSema.def

@@ -5642,7 +5642,7 @@ ERROR(preconcurrency_not_inheritance_clause,none,
 ERROR(preconcurrency_not_existential,none,
       "'preconcurrency' attribute cannot apply to non-protocol type %0", (Type))
 ERROR(preconcurrency_attr_disabled,none,
-      "attribute requires '-enable-experimental-feature PreconcurrencyConformances'", ())
+      "attribute requires '-enable-experimental-feature DynamicActorIsolation'", ())
 
 ERROR(redundant_any_in_existential,none,
        "redundant 'any' in type %0",

include/swift/AST/Expr.h

@@ -3519,6 +3519,19 @@ class BridgeToObjCExpr : public ImplicitConversionExpr {
   }
 };
 
+/// ActorIsolationErasureExpr - A special kind of function conversion that
+/// drops actor isolation.
+class ActorIsolationErasureExpr : public ImplicitConversionExpr {
+public:
+  ActorIsolationErasureExpr(Expr *subExpr, Type type)
+      : ImplicitConversionExpr(ExprKind::ActorIsolationErasure, subExpr, type) {
+  }
+
+  static bool classof(const Expr *E) {
+    return E->getKind() == ExprKind::ActorIsolationErasure;
+  }
+};
+
 /// UnresolvedSpecializeExpr - Represents an explicit specialization using
 /// a type parameter list (e.g. "Vector<Int>") that has not been resolved.
 class UnresolvedSpecializeExpr final : public Expr,

include/swift/AST/ExprNodes.def

@@ -189,7 +189,8 @@ ABSTRACT_EXPR(ImplicitConversion, Expr)
   EXPR(DifferentiableFunctionExtractOriginal, ImplicitConversionExpr)
   EXPR(LinearFunctionExtractOriginal, ImplicitConversionExpr)
   EXPR(LinearToDifferentiableFunction, ImplicitConversionExpr)
-  EXPR_RANGE(ImplicitConversion, Load, LinearToDifferentiableFunction)
+  EXPR(ActorIsolationErasure, ImplicitConversionExpr)
+  EXPR_RANGE(ImplicitConversion, Load, ActorIsolationErasure)
 ABSTRACT_EXPR(ExplicitCast, Expr)
   ABSTRACT_EXPR(CheckedCast, ExplicitCastExpr)
     EXPR(ForcedCheckedCast, CheckedCastExpr)

include/swift/AST/FileUnit.h

@@ -17,6 +17,7 @@
 #include "swift/AST/RawComment.h"
 #include "swift/Basic/BasicSourceInfo.h"
 #include "swift/Basic/Debug.h"
+#include "swift/Basic/Version.h"
 
 #include "llvm/ADT/PointerIntPair.h"
 
@@ -417,6 +418,10 @@ class LoadedFile : public FileUnit {
     assert(classof(this) && "invalid kind");
   }
 public:
+  /// Returns the language version that was used to compile the contents of this
+  /// file. An empty `Version` is returned if the information is not available.
+  virtual version::Version getLanguageVersionBuiltWith() const = 0;
+
   /// Returns an arbitrary string representing the storage backing this file.
   ///
   /// This is usually a filesystem path.

include/swift/AST/Module.h

@@ -1147,6 +1147,10 @@ class ModuleDecl
 
   SourceRange getSourceRange() const { return SourceRange(); }
 
+  /// Returns the language version that was used to compile this module.
+  /// An empty `Version` is returned if the information is not available.
+  version::Version getLanguageVersionBuiltWith() const;
+
   static bool classof(const DeclContext *DC) {
     if (auto D = DC->getAsDecl())
       return classof(D);

include/swift/Basic/Features.def

@@ -268,8 +268,10 @@ EXPERIMENTAL_FEATURE(GroupActorErrors, true)
 // Allow for the 'transferring' keyword to be applied to arguments and results.
 EXPERIMENTAL_FEATURE(TransferringArgsAndResults, true)
 
-// Enable `@preconcurrency` attribute on protocol conformances.
-EXPERIMENTAL_FEATURE(PreconcurrencyConformances, false)
+// Enable `@preconcurrency` attribute on protocol conformances and runtime checks
+// of actor isolation in @obj thunks and arguments of APIs that haven't yet adopted
+// strict concurrency checking.
+EXPERIMENTAL_FEATURE(DynamicActorIsolation, false)
 
 // Allow for `switch` of noncopyable values to be borrowing or consuming.
 EXPERIMENTAL_FEATURE(BorrowingSwitch, true)

include/swift/ClangImporter/ClangModule.h

@@ -17,6 +17,7 @@
 #define SWIFT_CLANGIMPORTER_CLANGMODULE_H
 
 #include "swift/AST/FileUnit.h"
+#include "swift/Basic/Version.h"
 #include "swift/ClangImporter/ClangImporter.h"
 #include "clang/AST/ExternalASTSource.h"
 #include "clang/Basic/Module.h"
@@ -109,6 +110,10 @@ class ClangModuleUnit final : public LoadedFile {
     llvm_unreachable("no private decls in Clang modules");
   }
 
+  virtual version::Version getLanguageVersionBuiltWith() const override {
+    return version::Version();
+  }
+
   virtual StringRef getFilename() const override;
 
   virtual StringRef getLoadedFilename() const override;

include/swift/Serialization/SerializedModuleLoader.h

@@ -400,7 +400,7 @@ class SerializedASTFile final : public LoadedFile {
 
   /// Returns the language version that was used to compile the contents of this
   /// file.
-  const version::Version &getLanguageVersionBuiltWith() const;
+  virtual version::Version getLanguageVersionBuiltWith() const override;
 
   virtual bool hadLoadError() const override;
 

lib/AST/ASTDumper.cpp

@@ -2695,6 +2695,13 @@ class PrintExpr : public ExprVisitor<PrintExpr, void, StringRef>,
     printFoot();
   }
 
+  void visitActorIsolationErasureExpr(ActorIsolationErasureExpr *E,
+                                      StringRef label) {
+    printCommon(E, "actor_isolation_erasure_expr", label);
+    printRec(E->getSubExpr());
+    printFoot();
+  }
+
   void visitInOutExpr(InOutExpr *E, StringRef label) {
     printCommon(E, "inout_expr", label);
     printRec(E->getSubExpr());