Merge pull request #76464 from kubamracek/embedded-fix-generics-check-in-perfdiags

[embedded] Fix generic function skipping in PerfDiags, diagnose KeyPathInsts in closures

Author: kubamracek

lib/SILOptimizer/Mandatory/PerformanceDiagnostics.cpp

@@ -203,7 +203,7 @@ bool PerformanceDiagnostics::visitFunctionEmbeddedSwift(
     SILFunction *function, LocWithParent *parentLoc) {
   // Don't check generic functions in embedded Swift, they're about to be
   // removed anyway.
-  if (function->getLoweredFunctionType()->getSubstGenericSignature())
+  if (function->isGeneric())
     return false;
 
   if (!function->isDefinition())

test/embedded/keypaths4.swift

@@ -0,0 +1,12 @@
+// RUN: %target-swift-emit-ir -verify %s -enable-experimental-feature Embedded -wmo
+
+// REQUIRES: swift_in_compiler
+// REQUIRES: optimized_stdlib
+// REQUIRES: OS=macosx || OS=linux-gnu
+
+public func foo() {
+  let number = 42
+  _ = withUnsafeBytes(of: number) { bytes in
+      bytes.map(\.description).joined(separator: ".") // expected-error {{cannot use key path in embedded Swift}}
+  }
+}