Merge pull request #39390 from hborla/prefer-variables-to-unapplied-functions

[ConstraintSystem] Prefer overloads choices that are variables over unapplied functions using the solver score.

Author: hborla

include/swift/Sema/ConstraintSystem.h

@@ -768,8 +768,18 @@ enum ScoreKind {
   SK_ValueToPointerConversion,
   /// A closure/function conversion to an autoclosure parameter.
   SK_FunctionToAutoClosureConversion,
-
-  SK_LastScoreKind = SK_FunctionToAutoClosureConversion,
+  /// An unapplied reference to a function. The purpose of this
+  /// score bit is to prune overload choices that are functions
+  /// when a solution has already been found using property.
+  ///
+  /// \Note The solver only prefers variables over functions
+  /// to resolve ambiguities, so please be sure that any score
+  /// kind added after this is truly less impactful. Only other
+  /// ambiguity tie-breakers should go after this; anything else
+  /// should be added above.
+  SK_UnappliedFunction,
+
+  SK_LastScoreKind = SK_UnappliedFunction,
 };
 
 /// The number of score kinds.

lib/Sema/CSRanking.cpp

@@ -90,6 +90,9 @@ static StringRef getScoreKindName(ScoreKind kind) {
 
   case SK_ImplicitValueConversion:
     return "value-to-value conversion";
+
+  case SK_UnappliedFunction:
+    return "overloaded unapplied function";
   }
 }
 

lib/Sema/ConstraintSystem.cpp

@@ -2947,6 +2947,12 @@ void ConstraintSystem::resolveOverload(ConstraintLocator *locator,
       }
     }
 
+    if (isa<AbstractFunctionDecl>(decl) || isa<TypeDecl>(decl)) {
+      if (choice.getFunctionRefKind() == FunctionRefKind::Unapplied) {
+        increaseScore(SK_UnappliedFunction);
+      }
+    }
+
     if (auto *afd = dyn_cast<AbstractFunctionDecl>(decl)) {
       // Check whether applying this overload would result in invalid
       // partial function application e.g. partial application of

validation-test/Sema/type_checker_perf/fast/property_vs_unapplied_func.swift

@@ -0,0 +1,30 @@
+// RUN: %target-typecheck-verify-swift -solver-expression-time-threshold=1 -solver-disable-shrink
+// REQUIRES: tools-release,no_asan
+
+struct Date {
+  var description: String
+  func description(with: Int) -> String { "" }
+}
+
+struct DatabaseLog {
+  let string: String
+  let values: [String]
+  let date: Date
+
+  var description: String {
+    return "[" + string + "] [" + date.description + "] " + string + " [" + values.joined(separator: ", ") + "]"
+  }
+}
+
+extension Sequence {
+  public func count(
+    where predicate: (Element) throws -> Bool
+  ) rethrows -> Int { 0 }
+}
+
+
+func rdar47742750(arr1: [Int], arr2: [Int]?) {
+  let _ = {
+    assert(arr1.count == arr1.count + (arr2 == nil ? 0 : 1 + arr2!.count + arr2!.count + arr2!.count))
+  }
+}