[ASTPrinter] Print custom attributes only if it's accessible

Author: rintaro

lib/AST/Attr.cpp

@@ -845,6 +845,18 @@ bool DeclAttribute::printImpl(ASTPrinter &Printer, const PrintOptions &Options,
     break;
   }
   case DAK_Custom: {
+
+    auto attr = cast<CustomAttr>(this);
+    if (auto type = attr->getType()) {
+      // Print custom attributes only if the attribute decl is accessible.
+      // FIXME: rdar://85477478 They should be rejected.
+      if (auto attrDecl = type->getNominalOrBoundGenericNominal()) {
+        if (attrDecl->getFormalAccess() < Options.AccessFilter) {
+          return false;
+        }
+      }
+    }
+
     if (!Options.IsForSwiftInterface)
       break;
     // For Swift interface, we should print result builder attributes

test/SourceKit/InterfaceGen/gen_custom_attributes.swift

@@ -8,11 +8,26 @@
 // RUN: %sourcekitd-test -req=interface-gen -module MyModule -- -target %target-triple -I %t | %FileCheck %s --check-prefix=SWIFTMODULE
 // RUN: %sourcekitd-test -req=doc-info -module MyModule -- -target %target-triple -I %t | %FileCheck %s --check-prefix=DOCINFO
 
+@available(SwiftStdlib 5.1, *)
+@globalActor
+public struct PublicActor {
+  public actor MyActor { }
+  public static let shared = MyActor()
+}
+
+@available(SwiftStdlib 5.1, *)
+@globalActor
+struct InternalActor {
+  actor MyActor { }
+  static let shared = MyActor()
+}
+
 @propertyWrapper
-public struct OrLess {
+public struct PublicOrLess {
   private var threshold: Int
   private var number: Int = 0
-  init(wrappedValue: Int, threshold: Int) {
+
+  public init(wrappedValue: Int, threshold: Int) {
     self.threshold = threshold
     self.wrappedValue = wrappedValue
   }
@@ -22,38 +37,78 @@ public struct OrLess {
   }
 }
 
+@propertyWrapper
+struct InternalOrLess {
+  private var threshold: Int
+  private var number: Int = 0
+
+  init(wrappedValue: Int, threshold: Int) {
+    self.threshold = threshold
+    self.wrappedValue = wrappedValue
+  }
+  var wrappedValue: Int {
+    get { return number }
+    set { number = min(newValue, 12) }
+  }
+}
+
 @resultBuilder
-public struct IntBuilder {
+public struct PublicBuilder {
     public static func buildBlock(_ val: Int) -> Int { val }
 }
 
+@resultBuilder
+struct InternalBuilder {
+  static func buildBlock(_ val: Int) -> Int { val }
+}
+
+
 public struct TestStruct {
 
   @MainActor public func mainActorMethod() {}
   @MainActor(unsafe) public func mainActorUnsafeMethod() {}
 
-  @OrLess(threshold: 12) public var twelveOrLess = 13
+  @available(SwiftStdlib 5.1, *)
+  @PublicActor public func publicActorMethod() {}
+  @available(SwiftStdlib 5.1, *)
+  @InternalActor public func internalActorMethod() {}
+
+  @PublicOrLess(threshold: 12) public var publicOrLess = 13
+  @InternalOrLess(threshold: 42) public var internalOrLess = 56
 
-  @IntBuilder public var intValue: Int { 1 }
+  @PublicBuilder public var publicBuilderVal: Int { 1 }
+  @InternalBuilder public var internalBuilderVal: Int { 1 }
 }
 
 // SWIFTSOURCE: public struct TestStruct {
 // SWIFTSOURCE:     @MainActor public func mainActorMethod()
 // SWIFTSOURCE:     @MainActor public func mainActorUnsafeMethod()
-// SWIFTSOURCE:     @MyModule.OrLess public var twelveOrLess: Int { get set }
-// SWIFTSOURCE:     @MyModule.IntBuilder public var intValue: Int { get }
+// SWIFTSOURCE:     @MyModule.PublicActor public func publicActorMethod()
+// SWIFTSOURCE:     @MyModule.InternalActor public func internalActorMethod()
+// SWIFTSOURCE:     @MyModule.PublicOrLess public var publicOrLess: Int { get set }
+// SWIFTSOURCE:     @MyModule.InternalOrLess public var internalOrLess: Int { get set }
+// SWIFTSOURCE:     @MyModule.PublicBuilder public var publicBuilderVal: Int { get }
+// SWIFTSOURCE:     @MyModule.InternalBuilder public var internalBuilderVal: Int { get }
 // SWIFTSOURCE: }
 
 // SWIFTMODULE: public struct TestStruct {
 // SWIFTMODULE:     @MainActor public func mainActorMethod()
 // SWIFTMODULE:     @MainActor public func mainActorUnsafeMethod()
-// SWIFTMODULE:     @MyModule.OrLess public var twelveOrLess: Int
-// SWIFTMODULE:     @MyModule.IntBuilder public var intValue: Int { get }
+// SWIFTMODULE:     @MyModule.PublicActor public func publicActorMethod()
+// SWIFTMODULE:     public func internalActorMethod()
+// SWIFTMODULE:     @MyModule.PublicOrLess public var publicOrLess: Int
+// SWIFTMODULE:     public var internalOrLess: Int
+// SWIFTMODULE:     @MyModule.PublicBuilder public var publicBuilderVal: Int { get }
+// SWIFTMODULE:     public var internalBuilderVal: Int { get }
 // SWIFTMODULE: }
 
 // DOCINFO: struct TestStruct {
 // DOCINFO:     @MainActor func mainActorMethod()
 // DOCINFO:     @MainActor func mainActorUnsafeMethod()
-// DOCINFO:     @MyModule.OrLess var twelveOrLess: Int
-// DOCINFO:     @MyModule.IntBuilder var intValue: Int { get }
+// DOCINFO:     @MyModule.PublicActor func publicActorMethod()
+// DOCINFO:     func internalActorMethod()
+// DOCINFO:     @MyModule.PublicOrLess var publicOrLess: Int
+// DOCINFO:     var internalOrLess: Int
+// DOCINFO:     @MyModule.PublicBuilder var publicBuilderVal: Int { get }
+// DOCINFO:     var internalBuilderVal: Int { get }
 // DOCINFO: }