Fix typos in diagnostics

Author: meg-gupta

include/swift/AST/DiagnosticsSema.def

@@ -7902,14 +7902,14 @@ ERROR(lifetime_dependence_invalid_return_type, none,
 ERROR(lifetime_dependence_cannot_infer_ambiguous_candidate, none,
       "cannot infer lifetime dependence %0, multiple parameters qualifiy as a candidate", (StringRef))
  ERROR(lifetime_dependence_cannot_infer_no_candidates, none,
-       "cannot infer lifetime dependence %0, no parameters found that are either "
+       "cannot infer lifetime dependence%0, no parameters found that are either "
        "~Escapable or Escapable with a borrowing ownership", (StringRef))
  ERROR(lifetime_dependence_ctor_non_self_or_nil_return, none,
        "expected nil or self as return values in an initializer with "
        "lifetime dependent specifiers",
        ())
  ERROR(lifetime_dependence_on_bitwise_copyable, none,
-       "invalid lifetime dependence on bitwise copyable type", ())
+       "invalid lifetime dependence on BitwiseCopyable type", ())
  ERROR(lifetime_dependence_cannot_be_applied_to_tuple_elt, none,
        "lifetime dependence specifiers cannot be applied to tuple elements", ())
  ERROR(lifetime_dependence_method_escapable_bitwisecopyable_self, none,

lib/AST/LifetimeDependence.cpp

@@ -165,7 +165,7 @@ static LifetimeDependenceKind getLifetimeDependenceKindFromDecl(
     return LifetimeDependenceKind::Scope;
   }
   if (parsedLifetimeDependenceKind == ParsedLifetimeDependenceKind::Inherit) {
-    // TODO: assert that this can happen only on deserialized decls
+    // TODO: assert that this can happen in SIL tests
     return LifetimeDependenceKind::Inherit;
   }
   return paramType->isEscapable() ? LifetimeDependenceKind::Scope
@@ -277,7 +277,7 @@ LifetimeDependenceInfo::fromTypeRepr(AbstractFunctionDecl *afd) {
     }
     case LifetimeDependenceSpecifier::SpecifierKind::Ordered: {
       auto index = specifier.getIndex();
-      if (index > afd->getParameters()->size()) {
+      if (index >= afd->getParameters()->size()) {
         diags.diagnose(specifier.getLoc(),
                        diag::lifetime_dependence_invalid_param_index, index);
         return std::nullopt;
@@ -495,7 +495,7 @@ LifetimeDependenceInfo::infer(AbstractFunctionDecl *afd) {
     if (cd && afd->isImplicit()) {
       diags.diagnose(returnLoc,
                      diag::lifetime_dependence_cannot_infer_no_candidates,
-                     "on implicit initializer");
+                     " on implicit initializer");
       return std::nullopt;
     }
     diags.diagnose(returnLoc,