AccessStorageAnalysis: ignore _swift_stdlib_malloc_size and _swift_stdlib_has_malloc_size runtime calls

Those runtime calls are used in the Array implementation and prevented access optimizations.

rdar://87853551

Author: eeckstein

include/swift/SILOptimizer/Analysis/AccessStorageAnalysis.h

@@ -295,10 +295,7 @@ class FunctionAccessStorage {
   /// the callee.
   ///
   /// TODO: Summarize ArraySemanticsCall accesses.
-  bool summarizeCall(FullApplySite fullApply) {
-    assert(accessResult.isEmpty() && "expected uninitialized results.");
-    return false;
-  }
+  bool summarizeCall(FullApplySite fullApply);
 
   /// Merge effects directly from \p RHS.
   bool mergeFrom(const FunctionAccessStorage &RHS) {

lib/SILOptimizer/Analysis/AccessStorageAnalysis.cpp

@@ -380,6 +380,19 @@ bool FunctionAccessStorage::summarizeFunction(SILFunction *F) {
   return true;
 }
 
+bool FunctionAccessStorage::summarizeCall(FullApplySite fullApply) {
+  assert(accessResult.isEmpty() && "expected uninitialized results.");
+  
+  if (SILFunction *callee = fullApply.getReferencedFunctionOrNull()) {
+    if (callee->getName() == "_swift_stdlib_malloc_size" ||
+        callee->getName() == "_swift_stdlib_has_malloc_size") {
+      return true;
+    }
+  }
+  
+  return false;
+}
+
 SILAnalysis *swift::createAccessStorageAnalysis(SILModule *) {
   return new AccessStorageAnalysis();
 }

test/SILOptimizer/access_enforcement_opts_ossa.sil

@@ -1874,3 +1874,23 @@ bb0(%0 : @owned $NonTrivial):
   destroy_value %0 : $NonTrivial
   return undef : $()
 }
+
+sil shared [clang _swift_stdlib_has_malloc_size] @_swift_stdlib_has_malloc_size : $@convention(c) () -> Bool
+sil shared [clang _swift_stdlib_malloc_size] @_swift_stdlib_malloc_size : $@convention(c) (UnsafeRawPointer) -> Int
+
+// CHECK-LABEL: sil [ossa] @ignoreMallocSize :
+// CHECK:         begin_access [read] [dynamic] [no_nested_conflict]
+// CHECK-LABEL: } // end sil function 'ignoreMallocSize'
+sil [ossa] @ignoreMallocSize : $@convention(thin) (UnsafeRawPointer) -> () {
+bb0(%0 : $UnsafeRawPointer):
+  %2 = global_addr @globalX: $*X
+  %3 = begin_access [read] [dynamic] %2 : $*X
+  %4 = function_ref @_swift_stdlib_has_malloc_size : $@convention(c) () -> Bool
+  %5 = apply %4() : $@convention(c) () -> Bool
+  %6 = function_ref @_swift_stdlib_malloc_size : $@convention(c) (UnsafeRawPointer) -> Int
+  %7 = apply %6(%0) : $@convention(c) (UnsafeRawPointer) -> Int
+  end_access %3 : $*X
+  %9 = tuple ()
+  return %9 : $()
+}
+

test/SILOptimizer/merge_exclusivity.swift

@@ -377,13 +377,13 @@ private struct EscapedTransforme<T>: WriteProt {
 
 // TESTSIL-LABEL: sil [noinline] @$s17merge_exclusivity14run_MergeTest9yySiF : $@convention(thin)
 // TESTSIL: [[REFADDR:%.*]] = ref_element_addr {{.*}} : $StreamClass, #StreamClass.buffer
-// TESTSIL-NEXT: [[B1:%.*]] = begin_access [modify] [dynamic] [no_nested_conflict] [[REFADDR]]
+// TESTSIL-NEXT: [[B1:%.*]] = begin_access [modify] [{{.*}}] [no_nested_conflict] [[REFADDR]]
 // TESTSIL: end_access [[B1]]
-// TESTSIL: [[BCONF:%.*]] = begin_access [modify] [dynamic] [[REFADDR]]
+// TESTSIL: [[BCONF:%.*]] = begin_access [modify] [{{.*}}] [[REFADDR]]
 // TESTSIL: end_access [[BCONF]]
-// TESTSIL: [[BCONF:%.*]] = begin_access [modify] [dynamic] [[REFADDR]]
+// TESTSIL: [[BCONF:%.*]] = begin_access [modify] [{{.*}}] [[REFADDR]]
 // TESTSIL: end_access [[BCONF]]
-// TESTSIL: [[BCONF:%.*]] = begin_access [modify] [dynamic] [[REFADDR]]
+// TESTSIL: [[BCONF:%.*]] = begin_access [modify] [{{.*}}] [[REFADDR]]
 // TESTSIL: end_access [[BCONF]]
 // TESTSIL-LABEL: } // end sil function '$s17merge_exclusivity14run_MergeTest9yySiF'
 @inline(never)