Factor the strict memory safety checking declarations into their own header

Author: DougGregor

lib/Sema/TypeCheckAvailability.cpp

@@ -19,6 +19,7 @@
 #include "TypeCheckConcurrency.h"
 #include "TypeCheckObjC.h"
 #include "TypeCheckType.h"
+#include "TypeCheckUnsafe.h"
 #include "TypeChecker.h"
 #include "swift/AST/ASTWalker.h"
 #include "swift/AST/AvailabilityDomain.h"

lib/Sema/TypeCheckAvailability.h

@@ -273,17 +273,6 @@ void checkExplicitAvailability(Decl *decl);
 std::pair<const Decl *, bool /*inDefinition*/>
 enclosingContextForUnsafe(SourceLoc referenceLoc, const DeclContext *referenceDC);
 
-/// Diagnose the given unsafe use right now.
-void diagnoseUnsafeUse(const UnsafeUse &use, bool asNote = false);
-
-/// Diagnose any unsafe uses within the signature or definition of the given
-/// declaration, if there are any.
-void diagnoseUnsafeUsesIn(const Decl *decl);
-
-/// Determine whether a reference to this declaration is considered unsafe,
-/// either explicitly (@unsafe) or because it references an unsafe type.
-bool isUnsafe(ConcreteDeclRef declRef);
-
 } // namespace swift
 
 #endif // SWIFT_SEMA_TYPE_CHECK_AVAILABILITY_H

lib/Sema/TypeCheckDeclOverride.cpp

@@ -20,6 +20,7 @@
 #include "TypeCheckEffects.h"
 #include "TypeCheckObjC.h"
 #include "TypeChecker.h"
+#include "TypeCheckUnsafe.h"
 #include "swift/AST/ASTVisitor.h"
 #include "swift/AST/Availability.h"
 #include "swift/AST/Decl.h"

lib/Sema/TypeCheckDeclPrimary.cpp

@@ -27,6 +27,7 @@
 #include "TypeCheckObjC.h"
 #include "TypeCheckType.h"
 #include "TypeChecker.h"
+#include "TypeCheckUnsafe.h"
 #include "swift/AST/ASTPrinter.h"
 #include "swift/AST/ASTVisitor.h"
 #include "swift/AST/ASTWalker.h"

lib/Sema/TypeCheckProtocol.cpp

@@ -27,6 +27,7 @@
 #include "TypeCheckEffects.h"
 #include "TypeCheckInvertible.h"
 #include "TypeCheckObjC.h"
+#include "TypeCheckUnsafe.h"
 #include "swift/AST/ASTContext.h"
 #include "swift/AST/ASTMangler.h"
 #include "swift/AST/ASTPrinter.h"

lib/Sema/TypeCheckStmt.cpp

@@ -20,6 +20,7 @@
 #include "TypeCheckDistributed.h"
 #include "TypeCheckType.h"
 #include "TypeChecker.h"
+#include "TypeCheckUnsafe.h"
 #include "swift/AST/ASTPrinter.h"
 #include "swift/AST/ASTScope.h"
 #include "swift/AST/ASTVisitor.h"

lib/Sema/TypeCheckUnsafe.cpp

@@ -14,14 +14,16 @@
 //
 //===----------------------------------------------------------------------===//
 
+#include "TypeCheckAvailability.h"
+#include "TypeCheckType.h"
+#include "TypeCheckUnsafe.h"
+
 #include "swift/AST/ASTContext.h"
 #include "swift/AST/UnsafeUse.h"
 #include "swift/AST/DiagnosticsSema.h"
 #include "swift/AST/PackConformance.h"
 #include "swift/AST/SourceFile.h"
 #include "swift/AST/SourceFileExtras.h"
-#include "TypeCheckAvailability.h"
-#include "TypeCheckType.h"
 
 using namespace swift;
 

lib/Sema/TypeCheckUnsafe.h

@@ -0,0 +1,33 @@
+//===--- TypeCheckUnasfe.h - Strict Safety Diagnostics ----------*- C++ -*-===//
+//
+// This source file is part of the Swift.org open source project
+//
+// Copyright (c) 2014 - 2017 Apple Inc. and the Swift project authors
+// Licensed under Apache License v2.0 with Runtime Library Exception
+//
+// See https://swift.org/LICENSE.txt for license information
+// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef SWIFT_SEMA_TYPE_CHECK_UNSAFE_H
+#define SWIFT_SEMA_TYPE_CHECK_UNSAFE_H
+
+#include "swift/AST/UnsafeUse.h"
+
+namespace swift {
+
+/// Diagnose the given unsafe use right now.
+void diagnoseUnsafeUse(const UnsafeUse &use, bool asNote = false);
+
+/// Diagnose any unsafe uses within the signature or definition of the given
+/// declaration, if there are any.
+void diagnoseUnsafeUsesIn(const Decl *decl);
+
+/// Determine whether a reference to this declaration is considered unsafe,
+/// either explicitly (@unsafe) or because it references an unsafe type.
+bool isUnsafe(ConcreteDeclRef declRef);
+
+}
+
+#endif // SWIFT_SEMA_TYPE_CHECK_UNSAFE_H