Merge pull request #80522 from ktoso/wip-better-assertion-pop-record

[Concurrency] Improve assertion to validate we pop the EXACT record we intend to

Author: ktoso

stdlib/public/Concurrency/Task.cpp

@@ -1794,9 +1794,11 @@ static void swift_task_removeCancellationHandlerImpl(
     return;
   }
 
+  auto task = swift_task_getCurrent();
+  assert(task->_private()._status().load(std::memory_order_relaxed).getInnermostRecord() == record &&
+    "We expect that the popped record will be exactly first as well as that it is of the expected type");
   if (auto poppedRecord =
-      popStatusRecordOfType<CancellationNotificationStatusRecord>(swift_task_getCurrent())) {
-    assert(record == poppedRecord && "The removed record did not match the expected record!");
+      popStatusRecordOfType<CancellationNotificationStatusRecord>(task)) {
     swift_task_dealloc(record);
   }
 }