Merge pull request #38320 from xedin/rdar-80271666

[CSGen] Don't apply one-way requirement to typed patterns

Author: xedin

lib/Sema/CSGen.cpp

@@ -2246,7 +2246,7 @@ namespace {
         Type subPatternType = getTypeForPattern(
             subPattern,
             locator.withPathElement(LocatorPathElt::PatternMatch(subPattern)),
-            openedType, bindPatternVarsOneWay);
+            openedType, /*bindPatternVarsOneWay*/false);
 
         if (!subPatternType)
           return Type();

validation-test/Sema/type_checker_crashers_fixed/sr14893.swift

@@ -0,0 +1,29 @@
+// RUN: %target-typecheck-verify-swift -target %target-cpu-apple-macosx10.15 -swift-version 5
+
+// REQUIRES: OS=macosx
+
+enum Category {
+case first
+}
+
+protocol View {}
+
+extension View {
+  func test(_ tag: Category) -> some View {
+    Image()
+  }
+}
+
+@resultBuilder struct ViewBuilder {
+  static func buildBlock<Content>(_ content: Content) -> Content where Content : View { fatalError() }
+}
+
+struct Image : View {
+}
+
+struct MyView {
+  @ViewBuilder var body: some View {
+    let icon: Category! = Category.first // expected-error {{using '!' is not allowed here; perhaps '?' was intended?}} {{23-24=?}}
+    Image().test(icon)
+  }
+}