[Distributed] Remove _distributedThunkTarget; it is not necessary (#72245)

Author: ktoso

include/swift/AST/Attr.h

@@ -2609,28 +2609,6 @@ class RawLayoutAttr final : public DeclAttribute {
   }
 };
 
-/// The @_distributedThunkTarget(for:) attribute.
-class DistributedThunkTargetAttr final
-    : public DeclAttribute {
-
-  AbstractFunctionDecl *TargetFunction;
-
-public:
-  DistributedThunkTargetAttr(AbstractFunctionDecl *target)
-      : DeclAttribute(DeclAttrKind::DistributedThunkTarget, SourceLoc(),
-                      SourceRange(),
-                      /*Implicit=*/false),
-        TargetFunction(target) {}
-
-  AbstractFunctionDecl *getTargetFunction() const {
-    return TargetFunction;
-  }
-
-  static bool classof(const DeclAttribute *DA) {
-    return DA->getKind() == DeclAttrKind::DistributedThunkTarget;
-  }
-};
-
 /// Predicate used to filter MatchingAttributeRange.
 template <typename ATTR, bool AllowInvalid> struct ToAttributeKind {
   ToAttributeKind() {}

include/swift/AST/DeclAttr.def

@@ -485,9 +485,7 @@ SIMPLE_DECL_ATTR(_noExistentials, NoExistentials,
 SIMPLE_DECL_ATTR(_noObjCBridging, NoObjCBridging,
   OnAbstractFunction | OnSubscript | UserInaccessible | ABIStableToAdd | ABIStableToRemove | APIStableToAdd | APIStableToRemove,
   155)
-DECL_ATTR(_distributedThunkTarget, DistributedThunkTarget,
-  OnAbstractFunction | UserInaccessible | ABIStableToAdd | ABIBreakingToRemove | APIStableToAdd | APIStableToRemove,
-  156)
+// Unused '156': Used to be `_distributedThunkTarget` but completed implementation in Swift 6.0 does not need it after all
 DECL_ATTR(_allowFeatureSuppression, AllowFeatureSuppression,
   OnAnyDecl | UserInaccessible | NotSerialized | ABIStableToAdd | APIStableToAdd | ABIStableToRemove | APIStableToRemove,
   157)

lib/AST/Attr.cpp

@@ -1918,8 +1918,6 @@ StringRef DeclAttribute::getAttrName() const {
     return "_section";
   case DeclAttrKind::Documentation:
     return "_documentation";
-  case DeclAttrKind::DistributedThunkTarget:
-    return "_distributedThunkTarget";
   case DeclAttrKind::Nonisolated:
     if (cast<NonisolatedAttr>(this)->isUnsafe()) {
         return "nonisolated(unsafe)";

lib/ASTGen/Sources/ASTGen/DeclAttrs.swift

@@ -256,8 +256,7 @@ extension ASTGenVisitor {
         .usableFromInline,
         .used,
         .warnUnqualifiedAccess,
-        .weakLinked,
-        .distributedThunkTarget:
+        .weakLinked:
 
         return self.generateSimpleDeclAttr(attribute: node, kind: attrKind)
 

lib/Parse/ParseDecl.cpp

@@ -3704,11 +3704,6 @@ ParserStatus Parser::parseNewDeclAttribute(DeclAttributes &Attributes,
     break;
   }
 
-  case DeclAttrKind::DistributedThunkTarget: {
-    assert(false && "Not implemented");
-    break;
-  }
-
   case DeclAttrKind::TypeEraser: {
     // Parse leading '('
     if (Tok.isNot(tok::l_paren)) {

lib/Sema/CodeSynthesisDistributedActor.cpp

@@ -751,10 +751,6 @@ static FuncDecl *createDistributedThunkFunction(FuncDecl *func) {
   if (func->hasBody())
     thunk->setBodySynthesizer(deriveBodyDistributed_thunk, func);
 
-  /// Record which function this is a thunk for, we'll need this to link back
-  /// calls in case this is a distributed requirement witness.
-  thunk->getAttrs().add(new (C) DistributedThunkTargetAttr(func));
-
   return thunk;
 }
 

lib/Sema/TypeCheckAttr.cpp

@@ -163,7 +163,6 @@ class AttributeChecker : public AttributeVisitor<AttributeChecker> {
   IGNORED_ATTR(BackDeployed)
   IGNORED_ATTR(Documentation)
   IGNORED_ATTR(LexicalLifetimes)
-  IGNORED_ATTR(DistributedThunkTarget)
   IGNORED_ATTR(AllowFeatureSuppression)
   IGNORED_ATTR(PreInverseGenerics)
 #undef IGNORED_ATTR

lib/Sema/TypeCheckDeclOverride.cpp

@@ -1636,7 +1636,6 @@ namespace  {
     UNINTERESTING_ATTR(NonEscapable)
     UNINTERESTING_ATTR(UnsafeNonEscapableResult)
     UNINTERESTING_ATTR(StaticExclusiveOnly)
-    UNINTERESTING_ATTR(DistributedThunkTarget)
     UNINTERESTING_ATTR(PreInverseGenerics)
 #undef UNINTERESTING_ATTR
 

lib/Serialization/ModuleFormat.h

@@ -2387,14 +2387,6 @@ namespace decls_block {
     BCArray<IdentifierIDField>
   >;
 
-  using DistributedThunkTargetDeclAttrLayout = BCRecordLayout<
-      DistributedThunkTarget_DECL_ATTR,
-      BCFixed<1>, // implicit flag
-      DeclIDField // target function
-          // FIXME: not entirely right?
-  >;
-
-
   using TypeEraserDeclAttrLayout = BCRecordLayout<
     TypeEraser_DECL_ATTR,
     BCFixed<1>, // implicit flag

lib/Serialization/Serialization.cpp

@@ -3065,9 +3065,6 @@ class Serializer::DeclSerializer : public DeclVisitor<DeclSerializer> {
           S.addDeclRef(afd), pieces.size(), pieces);
       return;
     }
-    case DeclAttrKind::DistributedThunkTarget: {
-      assert(false && "not implemented");
-    }
 
     case DeclAttrKind::TypeEraser: {
       auto abbrCode = S.DeclTypeAbbrCodes[TypeEraserDeclAttrLayout::Code];