Merge pull request #68769 from kubamracek/embedded-arm64e-destroy

[embedded] Fix arm64e pointer signing in embedded heap object destruction

Author: kubamracek

stdlib/public/SwiftShims/swift/shims/EmbeddedShims.h

@@ -28,14 +28,17 @@
 extern "C" {
 #endif
 
-#define SWIFT_CC __attribute__((swiftcall))
-#define SWIFT_CONTEXT __attribute__((swift_context))
-
-typedef void SWIFT_CC (*HeapObjectDestroyer)(SWIFT_CONTEXT void *object);
-
-static inline void _swift_runtime_invoke_heap_object_destroy(
-    const void *destroy, void *self) {
-  ((HeapObjectDestroyer)destroy)(self);
+typedef void __attribute__((swiftcall)) (*HeapObjectDestroyer)(
+    __attribute__((swift_context)) void *object);
+
+static inline void _swift_embedded_invoke_heap_object_destroy(void *object) {
+  void *metadata = *(void **)object;
+  void **destroy_location = &((void **)metadata)[1];
+#if __has_feature(ptrauth_calls)
+  (*(HeapObjectDestroyer __ptrauth(0,1,0xbbbf) *)destroy_location)(object);
+#else
+  (*(HeapObjectDestroyer *)destroy_location)(object);
+#endif
 }
 
 #ifdef __cplusplus

stdlib/public/core/EmbeddedRuntime.swift

@@ -117,7 +117,7 @@ public func swift_release(object: Builtin.RawPointer) {
   if o.pointee.refcount == HeapObject.immortalRefCount { return }
   o.pointee.refcount -= 1
   if (o.pointee.refcount & HeapObject.refcountMask) == 0 {
-    _swift_runtime_invoke_heap_object_destroy(o.pointee.metadata.pointee.destroy, o)
+    _swift_embedded_invoke_heap_object_destroy(o)
   }
 }