[MoveOnlyAddressChecker] Complete lifetimes first.

It relies on complete lifetimes for its analysis.  So if there are any
instructions to check, complete all lifetimes in the function first.

Author: nate-chandler

lib/SILOptimizer/Mandatory/MoveOnlyAddressCheckerTester.cpp

@@ -109,7 +109,8 @@ class MoveOnlyAddressCheckerTesterPass : public SILFunctionTransform {
       borrowtodestructure::IntervalMapAllocator allocator;
       MoveOnlyAddressChecker checker{getFunction(), diagnosticEmitter,
                                      allocator, domTree, poa};
-      madeChange = checker.check(moveIntroducersToProcess);
+      madeChange = checker.completeLifetimes();
+      madeChange |= checker.check(moveIntroducersToProcess);
     }
 
     // If we did not emit any diagnostics, emit a diagnostic if we missed any

lib/SILOptimizer/Mandatory/MoveOnlyAddressCheckerUtils.cpp

@@ -242,6 +242,7 @@
 #include "swift/SIL/FieldSensitivePrunedLiveness.h"
 #include "swift/SIL/InstructionUtils.h"
 #include "swift/SIL/MemAccessUtils.h"
+#include "swift/SIL/OSSALifetimeCompletion.h"
 #include "swift/SIL/OwnershipUtils.h"
 #include "swift/SIL/PrunedLiveness.h"
 #include "swift/SIL/SILArgument.h"
@@ -3986,3 +3987,29 @@ bool MoveOnlyAddressChecker::check(
   }
   return pimpl.changed;
 }
+bool MoveOnlyAddressChecker::completeLifetimes() {
+  // TODO: Delete once OSSALifetimeCompletion is run as part of SILGenCleanup
+  bool changed = false;
+
+  // Lifetimes must be completed inside out (bottom-up in the CFG).
+  PostOrderFunctionInfo *postOrder = poa->get(fn);
+  OSSALifetimeCompletion completion(fn, domTree);
+  for (auto *block : postOrder->getPostOrder()) {
+    for (SILInstruction &inst : reverse(*block)) {
+      for (auto result : inst.getResults()) {
+        if (completion.completeOSSALifetime(result) ==
+            LifetimeCompletion::WasCompleted) {
+          changed = true;
+        }
+      }
+    }
+    for (SILArgument *arg : block->getArguments()) {
+      assert(!arg->isReborrow() && "reborrows not legal at this SIL stage");
+      if (completion.completeOSSALifetime(arg) ==
+          LifetimeCompletion::WasCompleted) {
+        changed = true;
+      }
+    }
+  }
+  return changed;
+}

lib/SILOptimizer/Mandatory/MoveOnlyAddressCheckerUtils.h

@@ -44,6 +44,7 @@ struct MoveOnlyAddressChecker {
   /// \p diagnosticEmitter.getDiagnosticCount().
   bool check(llvm::SmallSetVector<MarkUnresolvedNonCopyableValueInst *, 32>
                  &moveIntroducersToProcess);
+  bool completeLifetimes();
 };
 
 } // namespace siloptimizer

lib/SILOptimizer/Mandatory/MoveOnlyChecker.cpp

@@ -202,6 +202,7 @@ void MoveOnlyChecker::checkAddresses() {
 
   MoveOnlyAddressChecker checker{fn, diagnosticEmitter, allocator, domTree,
                                  poa};
+  madeChange |= checker.completeLifetimes();
   madeChange |= checker.check(moveIntroducersToProcess);
 }