Gardening: Use const consistently for ASTContext parameters.

Author: tshortli

include/swift/AST/AvailabilityContext.h

@@ -52,16 +52,16 @@ class AvailabilityContext {
   /// Retrieves an `AvailabilityContext` constrained by the given platform
   /// availability range.
   static AvailabilityContext forPlatformRange(const AvailabilityRange &range,
-                                              ASTContext &ctx);
+                                              const ASTContext &ctx);
 
   /// Retrieves the maximally available `AvailabilityContext` for the
   /// compilation. The platform availability range will be set to the minimum
   /// inlining target (which may just be the deployment target).
-  static AvailabilityContext forInliningTarget(ASTContext &ctx);
+  static AvailabilityContext forInliningTarget(const ASTContext &ctx);
 
   /// Retrieves an `AvailabilityContext` with the platform availability range
   /// set to the deployment target.
-  static AvailabilityContext forDeploymentTarget(ASTContext &ctx);
+  static AvailabilityContext forDeploymentTarget(const ASTContext &ctx);
 
   /// Returns the range of platform versions which may execute code in the
   /// availability context, starting at its introduction version.
@@ -77,16 +77,17 @@ class AvailabilityContext {
   bool isDeprecated() const;
 
   /// Constrain with another `AvailabilityContext`.
-  void constrainWithContext(const AvailabilityContext &other, ASTContext &ctx);
+  void constrainWithContext(const AvailabilityContext &other,
+                            const ASTContext &ctx);
 
   /// Constrain the platform availability range with `platformRange`.
   void constrainWithPlatformRange(const AvailabilityRange &platformRange,
-                                  ASTContext &ctx);
+                                  const ASTContext &ctx);
 
   /// Constrain the context by adding \p domain to the set of unavailable
   /// domains.
   void constrainWithUnavailableDomain(AvailabilityDomain domain,
-                                      ASTContext &ctx);
+                                      const ASTContext &ctx);
 
   /// Constrain with the availability attributes of `decl`.
   void constrainWithDecl(const Decl *decl);
@@ -114,7 +115,7 @@ class AvailabilityContext {
   SWIFT_DEBUG_DUMP;
 
   /// Returns true if all internal invariants are satisfied.
-  bool verify(ASTContext &ctx) const;
+  bool verify(const ASTContext &ctx) const;
 };
 
 } // end namespace swift

include/swift/AST/AvailabilityContextStorage.h

@@ -48,7 +48,7 @@ class AvailabilityContext::Info {
   /// restrictive than the current values. Returns true if any field was
   /// updated.
   bool constrainWith(const DeclAvailabilityConstraints &constraints,
-                     ASTContext &ctx);
+                     const ASTContext &ctx);
 
   bool constrainUnavailability(
       const llvm::SmallVectorImpl<AvailabilityDomain> &domains);
@@ -63,7 +63,7 @@ class AvailabilityContext::Info {
   void Profile(llvm::FoldingSetNodeID &ID) const;
 
   /// Returns true if all internal invariants are satisfied.
-  bool verify(ASTContext &ctx) const;
+  bool verify(const ASTContext &ctx) const;
 };
 
 /// As an implementation detail, the values that make up an `Availability`
@@ -74,7 +74,7 @@ class AvailabilityContext::Storage final : public llvm::FoldingSetNode {
 public:
   Info info;
 
-  static const Storage *get(const Info &info, ASTContext &ctx);
+  static const Storage *get(const Info &info, const ASTContext &ctx);
 
   void Profile(llvm::FoldingSetNodeID &ID) const { info.Profile(ID); }
 };

lib/AST/ASTContext.cpp

@@ -5714,7 +5714,7 @@ SubstitutionMap::Storage *SubstitutionMap::Storage::get(
 }
 
 const AvailabilityContext::Storage *
-AvailabilityContext::Storage::get(const Info &info, ASTContext &ctx) {
+AvailabilityContext::Storage::get(const Info &info, const ASTContext &ctx) {
   llvm::FoldingSetNodeID id;
   info.Profile(id);
 

lib/AST/AvailabilityContext.cpp

@@ -48,7 +48,7 @@ bool AvailabilityContext::Info::constrainWith(const Info &other) {
 }
 
 bool AvailabilityContext::Info::constrainWith(
-    const DeclAvailabilityConstraints &constraints, ASTContext &ctx) {
+    const DeclAvailabilityConstraints &constraints, const ASTContext &ctx) {
   bool isConstrained = false;
 
   for (auto constraint : constraints) {
@@ -155,7 +155,7 @@ void AvailabilityContext::Info::Profile(llvm::FoldingSetNodeID &ID) const {
   ID.AddBoolean(IsDeprecated);
 }
 
-bool AvailabilityContext::Info::verify(ASTContext &ctx) const {
+bool AvailabilityContext::Info::verify(const ASTContext &ctx) const {
   // Unavailable domains must be sorted to ensure folding set node lookups yield
   // consistent results.
   if (!llvm::is_sorted(UnavailableDomains,
@@ -167,18 +167,20 @@ bool AvailabilityContext::Info::verify(ASTContext &ctx) const {
 
 AvailabilityContext
 AvailabilityContext::forPlatformRange(const AvailabilityRange &range,
-                                      ASTContext &ctx) {
+                                      const ASTContext &ctx) {
   Info info{range, /*UnavailableDomains*/ {},
             /*IsDeprecated*/ false};
   return AvailabilityContext(Storage::get(info, ctx));
 }
 
-AvailabilityContext AvailabilityContext::forInliningTarget(ASTContext &ctx) {
+AvailabilityContext
+AvailabilityContext::forInliningTarget(const ASTContext &ctx) {
   return AvailabilityContext::forPlatformRange(
       AvailabilityRange::forInliningTarget(ctx), ctx);
 }
 
-AvailabilityContext AvailabilityContext::forDeploymentTarget(ASTContext &ctx) {
+AvailabilityContext
+AvailabilityContext::forDeploymentTarget(const ASTContext &ctx) {
   return AvailabilityContext::forPlatformRange(
       AvailabilityRange::forDeploymentTarget(ctx), ctx);
 }
@@ -205,7 +207,7 @@ bool AvailabilityContext::isDeprecated() const {
 }
 
 void AvailabilityContext::constrainWithContext(const AvailabilityContext &other,
-                                               ASTContext &ctx) {
+                                               const ASTContext &ctx) {
   bool isConstrained = false;
 
   Info info{storage->info};
@@ -218,7 +220,7 @@ void AvailabilityContext::constrainWithContext(const AvailabilityContext &other,
 }
 
 void AvailabilityContext::constrainWithPlatformRange(
-    const AvailabilityRange &platformRange, ASTContext &ctx) {
+    const AvailabilityRange &platformRange, const ASTContext &ctx) {
 
   Info info{storage->info};
   if (!constrainRange(info.Range, platformRange))
@@ -228,7 +230,7 @@ void AvailabilityContext::constrainWithPlatformRange(
 }
 
 void AvailabilityContext::constrainWithUnavailableDomain(
-    AvailabilityDomain domain, ASTContext &ctx) {
+    AvailabilityDomain domain, const ASTContext &ctx) {
   Info info{storage->info};
   if (!info.constrainUnavailability(domain))
     return;
@@ -289,6 +291,6 @@ void AvailabilityContext::print(llvm::raw_ostream &os) const {
 
 void AvailabilityContext::dump() const { print(llvm::errs()); }
 
-bool AvailabilityContext::verify(ASTContext &ctx) const {
+bool AvailabilityContext::verify(const ASTContext &ctx) const {
   return storage->info.verify(ctx);
 }