Commit 7fd2e46
committed
[sil] Move mark_unresolved_move_addr in SILNodes.def so it is not classified as a SingleValueInstruction.
The specific problem here is that this causes MarkUnresolvedMoveAddr to be
within the SINGLE_VALUE_INST_RANGE which defines the classify method used to
determine if casting to a SingleValueInstruction is ok. This is of course not ok
in this case since mark_unresolved_move_addr is actually a NonValueInst.
I noticed this b/c I made the same mistake with a new instruction I am added and
hit a crash in the tests as a result of it being classified as a single value
instruction. After fixing that, I checked for any more instances of this issue
and found that mark_unresolved_move_addr was similarly afflicted.1 parent 110041b commit 7fd2e46
1 file changed
+7
-6
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
518 | 518 | | |
519 | 519 | | |
520 | 520 | | |
521 | | - | |
522 | | - | |
523 | | - | |
524 | | - | |
525 | | - | |
526 | | - | |
527 | 521 | | |
528 | 522 | | |
529 | 523 | | |
| |||
893 | 887 | | |
894 | 888 | | |
895 | 889 | | |
| 890 | + | |
| 891 | + | |
| 892 | + | |
| 893 | + | |
| 894 | + | |
| 895 | + | |
| 896 | + | |
896 | 897 | | |
897 | 898 | | |
898 | 899 | | |
| |||
0 commit comments