Skip to content

Commit 7f5dd0c

Browse files
committed
NFC: use -Werror flags in all Darwin tests
Running only during smoke tests mean that a PR merged with a full test can introduce build failures.
1 parent 9c63a56 commit 7f5dd0c

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

utils/build-presets.ini

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -347,6 +347,11 @@ skip-test-cmark
347347

348348
build-embedded-stdlib-cross-compiling
349349

350+
# Escalate certain C++ warnings to errors for Swift.
351+
extra-swift-cmake-options=
352+
-DSWIFT_EXTRA_CXX_FLAGS="-Werror=unused -Werror=uninitialized -Werror=implicit-fallthrough"
353+
354+
350355
[preset: buildbot_incremental_base_all_platforms]
351356
mixin-preset=buildbot_incremental_base
352357

@@ -679,10 +684,6 @@ skip-test-llbuild
679684

680685
enable-new-runtime-build
681686

682-
# Escalate certain C++ warnings to errors for Swift.
683-
extra-swift-cmake-options=
684-
-DSWIFT_EXTRA_CXX_FLAGS="-Werror=unused -Werror=uninitialized -Werror=implicit-fallthrough"
685-
686687
[preset: buildbot_incremental,tools=RA,stdlib=RD,smoketest=macosx,flto]
687688
mixin-preset=buildbot_incremental,tools=RA,stdlib=RD,smoketest=macosx
688689
build-subdir=buildbot_incremental

0 commit comments

Comments
 (0)