[Completion] Use TypeAttr.def for simple type attributes

Pick up all non-underscored simple type attributes
for code completion, and add support for
`@isolated(any)`.

rdar://130741006
rdar://130288443

Author: hamishknight

include/swift/AST/Attr.h

@@ -3055,6 +3055,10 @@ class alignas(1 << AttrAlignInBits) TypeAttribute
   /// Return the name (like "autoclosure") for an attribute ID.
   static const char *getAttrName(TypeAttrKind kind);
 
+  /// Returns whether the given attribute is considered "user inaccessible",
+  /// which affects e.g whether it shows up in code completion.
+  static bool isUserInaccessible(TypeAttrKind DK);
+
   static TypeAttribute *createSimple(const ASTContext &context,
                                      TypeAttrKind kind,
                                      SourceLoc atLoc,

lib/AST/Attr.cpp

@@ -145,6 +145,24 @@ const char *TypeAttribute::getAttrName(TypeAttrKind kind) {
   llvm_unreachable("unknown type attribute kind");
 }
 
+bool TypeAttribute::isUserInaccessible(TypeAttrKind DK) {
+  // Currently we can base this off whether it is underscored or for SIL.
+  // TODO: We could introduce a similar options scheme to DECL_ATTR if we ever
+  // need a user-inaccessible non-underscored attribute.
+  switch (DK) {
+    // SIL attributes are always considered user-inaccessible.
+#define SIL_TYPE_ATTR(SPELLING, C)                                             \
+  case TypeAttrKind::C:                                                        \
+    return true;
+    // For non-SIL attributes, check whether the spelling is underscored.
+#define TYPE_ATTR(SPELLING, C)                                                 \
+  case TypeAttrKind::C:                                                        \
+    return StringRef(#SPELLING).starts_with("_");
+#include "swift/AST/TypeAttr.def"
+  }
+  llvm_unreachable("unhandled case in switch!");
+}
+
 TypeAttribute *TypeAttribute::createSimple(const ASTContext &context,
                                            TypeAttrKind kind,
                                            SourceLoc atLoc,

lib/IDE/CompletionLookup.cpp

@@ -3137,12 +3137,21 @@ void CompletionLookup::getTypeAttributeKeywordCompletions() {
         CodeCompletionResultKind::Keyword, SemanticContextKind::None);
     Builder.addAttributeKeyword(Name, "Type Attribute");
   };
-  addTypeAttr("autoclosure");
+
+  // Add simple user-accessible attributes.
+#define SIL_TYPE_ATTR(SPELLING, C)
+#define SIMPLE_SIL_TYPE_ATTR(SPELLING, C)
+#define SIMPLE_TYPE_ATTR(SPELLING, C)                      \
+  if (!TypeAttribute::isUserInaccessible(TypeAttrKind::C)) \
+    addTypeAttr(#SPELLING);
+#include "swift/AST/TypeAttr.def"
+
+  // Add non-simple cases.
   addTypeAttr("convention(swift)");
   addTypeAttr("convention(block)");
   addTypeAttr("convention(c)");
   addTypeAttr("convention(thin)");
-  addTypeAttr("escaping");
+  addTypeAttr("isolated(any)");
 }
 
 void CompletionLookup::collectPrecedenceGroups() {