Merge pull request #36992 from ahoppen/pr/wrapping-lvalue

[TypeChecker] Clear param specifiers before re-typechecking expression for completion

Author: ahoppen

lib/Sema/TypeCheckCodeCompletion.cpp

@@ -242,6 +242,9 @@ class SanitizeExpr : public ASTWalker {
       if (auto closure = dyn_cast<ClosureExpr>(expr)) {
         if (!shouldTypeCheckInEnclosingExpression(closure))
           return { false, expr };
+        for (auto &Param : *closure->getParameters()) {
+          Param->setSpecifier(swift::ParamSpecifier::Default);
+        }
       }
 
       // Now, we're ready to walk into sub expressions.

validation-test/IDE/crashers_2_fixed/sr14494.swift

@@ -0,0 +1,37 @@
+// RUN: %target-swift-ide-test -code-completion -code-completion-token=COMPLETE -source-filename=%s | %FileCheck %s
+
+protocol MyView {
+    associatedtype Body : MyView
+    @MyViewBuilder var body: Self.Body { get }
+}
+
+@resultBuilder public struct MyViewBuilder {
+    static func buildBlock() -> MyZStack<Never> { fatalError() }
+    static func buildBlock<Content>(_ content: Content) -> Content { content }
+}
+
+struct MyAlignment {
+  static let center: MyAlignment
+}
+
+struct MyZStack<Content> : MyView {
+    init(alignment: MyAlignment, @MyViewBuilder content: () -> Content) {
+        fatalError()
+    }
+
+    func my_updating<State>(body: (inout State) -> Void) {}
+}
+
+struct BottomMenu: MyView {
+    var body: some MyView {
+        let a = MyZStack(alignment: .#^COMPLETE^#center, content: {})
+        .my_updating(body: { state in
+            state = false
+        })
+    }
+}
+
+// CHECK: Begin completions, 2 items
+// CHECK: Decl[StaticVar]/ExprSpecific/TypeRelation[Identical]: center[#MyAlignment#]; name=center
+// CHECK: Decl[Constructor]/CurrNominal/TypeRelation[Identical]: init()[#MyAlignment#]; name=init()
+// CHECK: End completions