Merge pull request #72690 from kubamracek/embedded-subclassing-across-modules

[embedded] Relax verifier check on hidden-external functions in embedded mode

Author: kubamracek

lib/SIL/Verifier/SILVerifier.cpp

@@ -7036,7 +7036,7 @@ class SILVerifier : public SILVerifierBase<SILVerifier> {
               "package-external function definition must be serialized");
       break;
     case SILLinkage::HiddenExternal:
-      require(F->isExternalDeclaration(),
+      require(F->isExternalDeclaration() || embedded,
               "hidden-external function cannot have a body");
       break;
     }

test/embedded/modules-subclasses.swift

@@ -0,0 +1,29 @@
+// RUN: %empty-directory(%t)
+// RUN: %{python} %utils/split_file.py -o %t %s
+
+// RUN: %target-swift-frontend -emit-module -o %t/MyModule.swiftmodule %t/MyModule.swift -enable-experimental-feature Embedded -parse-as-library
+// RUN: %target-swift-frontend -c -I %t %t/Main.swift -enable-experimental-feature Embedded -o %t/a.o
+// RUN: %target-clang -x c -c %S/Inputs/print.c -o %t/print.o
+// RUN: %target-clang %t/a.o %t/print.o -o %t/a.out
+// RUN: %target-run %t/a.out | %FileCheck %s
+
+// REQUIRES: swift_in_compiler
+// REQUIRES: executable_test
+// REQUIRES: OS=macosx || OS=linux-gnu
+
+// BEGIN MyModule.swift
+
+open class Foo {
+    public init() {}
+    func test() {}
+}
+
+// BEGIN Main.swift
+
+import MyModule
+
+class Bar: Foo {}
+
+print("OK!")
+
+// CHECK: OK!