Merge pull request #37238 from ahoppen/pr/dont-print-dollar-internal-labels

[AST] Don’t print internal function labels if they start with '$'

Author: ahoppen

lib/AST/ASTPrinter.cpp

@@ -4869,11 +4869,13 @@ class TypePrinter : public TypeVisitor<TypePrinter> {
                           PrintNameContext::FunctionParameterExternal);
         Printer << ": ";
       } else if (Options.AlwaysTryPrintParameterLabels &&
-                 Param.hasInternalLabel()) {
+                 Param.hasInternalLabel() &&
+                 !Param.getInternalLabel().hasDollarPrefix()) {
         // We didn't have an external parameter label but were requested to
-        // always try and print parameter labels. Print The internal label.
-        // If we have neither an external nor an internal label, only print the
-        // type.
+        // always try and print parameter labels.
+        // If the internal label is a valid internal parameter label (does not
+        // start with '$'), print the internal label. If we have neither an
+        // external nor a printable internal label, only print the type.
         Printer << "_ ";
         Printer.printName(Param.getInternalLabel(),
                           PrintNameContext::FunctionParameterLocal);

test/ModuleInterface/closure.swift

@@ -0,0 +1,12 @@
+// RUN: %empty-directory(%t)
+
+// RUN: %target-swift-frontend -typecheck %s -emit-module-interface-path %t/main.swiftinterface -enable-library-evolution
+// RUN: %FileCheck %s < %t/main.swiftinterface
+
+// CHECK: import Swift
+
+// CHECK: public let MyClosureVar: (Swift.Int) -> Swift.Int
+public let MyClosureVar: (Int) -> Int = { $0 }
+
+// CHECK: public var MyOtherClosureVar: (_ x: Swift.Int) -> Swift.Int
+public let MyOtherClosureVar: (_ x: Int) -> Int