Rename CSFix::affectsSolutionScore() to impact().

Author: DougGregor

include/swift/Sema/CSFix.h

@@ -442,9 +442,8 @@ class ConstraintFix {
     }
   }
 
-  /// Whether this kind of fix affects the solution score, and which score
-  /// it affects.
-  Optional<ScoreKind> affectsSolutionScore() const;
+  /// Determine the impact of this fix on the solution score, if any.
+  Optional<ScoreKind> impact() const;
 
   /// The diagnostic behavior limit that will be applied to any emitted
   /// diagnostics.

lib/Sema/CSApply.cpp

@@ -9129,7 +9129,7 @@ Optional<SolutionApplicationTarget> ConstraintSystem::applySolution(
     for (const auto fix : solution.Fixes) {
       if (fix->isFatal())
         canApplySolution = false;
-      if (fix->affectsSolutionScore() == SK_Fix && !fix->isFatal())
+      if (fix->impact() == SK_Fix && !fix->isFatal())
         ++numResolvableFixes;
     }
 

lib/Sema/CSFix.cpp

@@ -37,7 +37,7 @@ using namespace constraints;
 
 ConstraintFix::~ConstraintFix() {}
 
-Optional<ScoreKind> ConstraintFix::affectsSolutionScore() const {
+Optional<ScoreKind> ConstraintFix::impact() const {
   switch (fixBehavior) {
   case FixBehavior::AlwaysWarning:
     return None;

lib/Sema/CSSimplify.cpp

@@ -12711,8 +12711,8 @@ bool ConstraintSystem::recordFix(ConstraintFix *fix, unsigned impact) {
   // Record the fix.
 
   // If this should affect the solution score, do so.
-  if (auto scoreKind = fix->affectsSolutionScore())
-    increaseScore(*scoreKind, impact);
+  if (auto impactScoreKind = fix->impact())
+    increaseScore(*impactScoreKind, impact);
 
   // If we've made the current solution worse than the best solution we've seen
   // already, stop now.
@@ -12735,7 +12735,7 @@ bool ConstraintSystem::recordFix(ConstraintFix *fix, unsigned impact) {
     // Fixes that don't affect the score shouldn't be considered because even
     // if such a fix is recorded at that anchor this should not
     // have any affect in the recording of any other fix.
-    if (!fix->affectsSolutionScore())
+    if (!fix->impact())
       continue;
 
     anchors.insert(fix->getAnchor());

lib/Sema/ConstraintSystem.cpp

@@ -4638,7 +4638,7 @@ bool ConstraintSystem::diagnoseAmbiguityWithFixes(
       // source of ambiguity or failures.
       // Ignore warnings in favor of actual error fixes,
       // because they are not the source of ambiguity/failures.
-      if (!fix->affectsSolutionScore())
+      if (!fix->impact())
         continue;
 
       fixes.insert({&solution, fix});