Merge pull request #72026 from tshortli/resolve-astgen-warnings

Author: tshortli

lib/ASTGen/Sources/ASTGen/DeclAttrs.swift

@@ -395,6 +395,7 @@ extension ASTGenVisitor {
       return []
     }
 
+    _ = args
     fatalError("unimplemented")
   }
 
@@ -785,6 +786,7 @@ extension ASTGenVisitor {
       return []
     }
 
+    _ = args
     fatalError("unimplemented")
   }
 
@@ -962,11 +964,13 @@ extension ASTGenVisitor {
 
   func generateCustomAttr(attribute node: AttributeSyntax) -> BridgedCustomAttr? {
     guard
-      var args = node.arguments?.as(LabeledExprListSyntax.self)?[...]
+      let args = node.arguments?.as(LabeledExprListSyntax.self)?[...]
     else {
       // TODO: Diagnose.
       return nil
     }
+
+    _ = args
     fatalError("unimplemented")
   }
 

lib/ASTGen/Sources/ASTGen/DiagnosticsBridge.swift

@@ -141,7 +141,9 @@ extension DiagnosticSeverity {
     case .note: return .note
     case .warning: return .warning
     case .remark: return .remark
+#if RESILIENT_SWIFT_SYNTAX
     @unknown default: return .error
+#endif
     }
   }
 }

lib/ASTGen/Sources/ASTGen/Exprs.swift

@@ -266,6 +266,7 @@ extension ASTGenVisitor {
 
     if let signature = node.signature {
       // FIXME: Translate the signature, capture list, 'in' location, etc.
+      _ = signature
       fatalError("unimplmented")
     } else {
       let lBraceLoc = self.generateSourceLoc(node.leftBrace)
@@ -316,7 +317,7 @@ extension ASTGenVisitor {
     additionalTrailingClosures: MultipleTrailingClosureElementListSyntax?
   ) -> BridgedArgumentList {
 
-    var bridgedArgs: BridgedArrayRef = {
+    let bridgedArgs: BridgedArrayRef = {
       // Arguments before ')'
       let normalArgs = labeledExprList.lazy.map({ elem in
         let labelInfo = elem.label.map(self.generateIdentifierAndSourceLoc(_:))
@@ -362,7 +363,7 @@ extension ASTGenVisitor {
     // of the normal arguments because we don't have a convenient way to pass
     // Optional to ASTBridging,  ASTBridging can know it's "nil" if
     // bridgedArgs.count == firstTrailingClosureIndex
-    var firstTrailingClosureIndex = labeledExprList.count
+    let firstTrailingClosureIndex = labeledExprList.count
 
     return BridgedArgumentList.createParsed(
       self.ctx,

lib/ASTGen/Sources/ASTGen/PluginHost.swift

@@ -270,7 +270,9 @@ class PluginDiagnosticsEngine {
     case .note: bridgedSeverity = .note
     case .warning: bridgedSeverity = .warning
     case .remark: bridgedSeverity = .remark
+#if RESILIENT_SWIFT_SYNTAX
     @unknown default: bridgedSeverity = .error
+#endif
     }
 
     // Emit the diagnostic

lib/ASTGen/Sources/ASTGen/TypeAttrs.swift

@@ -31,6 +31,10 @@ extension ASTGenVisitor {
         attrs.add(attr);
       case .ifConfigDecl:
         fatalError("unimplemented")
+#if RESILIENT_SWIFT_SYNTAX
+      @unknown default:
+        fatalError()
+#endif
       }
     }