NFC: Rename priority set during task creation to be RequestedPriority

Radar-Id: rdar://problem/86100376

Author: rokhinip

include/swift/ABI/MetadataValues.h

@@ -2032,8 +2032,9 @@ inline int descendingPriorityOrder(JobPriority lhs,
 class TaskCreateFlags : public FlagSet<size_t> {
 public:
   enum {
-    Priority       = 0,
-    Priority_width = 8,
+    // Priority that user specified while creating the task
+    RequestedPriority = 0,
+    RequestedPriority_width = 8,
 
     Task_IsChildTask                              = 8,
     // bit 9 is unused
@@ -2046,8 +2047,9 @@ class TaskCreateFlags : public FlagSet<size_t> {
   explicit constexpr TaskCreateFlags(size_t bits) : FlagSet(bits) {}
   constexpr TaskCreateFlags() {}
 
-  FLAGSET_DEFINE_FIELD_ACCESSORS(Priority, Priority_width, JobPriority,
-                                 getPriority, setPriority)
+  FLAGSET_DEFINE_FIELD_ACCESSORS(RequestedPriority, RequestedPriority_width,
+                                 JobPriority, getRequestedPriority,
+                                 setRequestedPriority)
   FLAGSET_DEFINE_FLAG_ACCESSORS(Task_IsChildTask,
                                 isChildTask,
                                 setIsChildTask)

stdlib/public/Concurrency/Task.cpp

@@ -488,7 +488,7 @@ static AsyncTaskAndContext swift_task_create_commonImpl(
   TaskCreateFlags taskCreateFlags(rawTaskCreateFlags);
 
   // Propagate task-creation flags to job flags as appropriate.
-  JobFlags jobFlags(JobKind::Task, taskCreateFlags.getPriority());
+  JobFlags jobFlags(JobKind::Task, taskCreateFlags.getCreationPriority());
   jobFlags.task_setIsChildTask(taskCreateFlags.isChildTask());
   if (futureResultType) {
     jobFlags.task_setIsFuture(true);

unittests/runtime/Actor.cpp

@@ -140,9 +140,9 @@ static std::pair<AsyncTask*, Context*>
 createTaskWithContext(JobPriority priority, Fn &&fn) {
   auto invoke =
     TaskContinuationFromLambda<Fn, Context>::get(std::move(fn));
-  TaskCreateFlags flags;
-  flags.setPriority(priority);
-  auto pair = swift_task_create_common(flags.getOpaqueValue(),
+  TaskCreateFlags createFlags;
+  createFlags.setRequestedPriority(priority);
+  auto pair = swift_task_create_common(createFlags.getOpaqueValue(),
                                        nullptr,
                                        nullptr,
                                        invoke,