fix locating constructor

Author: ktoso

lib/Sema/TypeCheckDistributed.cpp

@@ -721,13 +721,13 @@ GetDistributedRemoteCallTargetInitFunctionRequest::evaluate(
     if (params->size() != 1)
       return nullptr;
 
-    if (params->get(0)->getArgumentName() == C.getIdentifier("_mangledName"))
+    // _ identifier
+    if (params->get(0)->getArgumentName().empty())
       return ctor;
 
     return nullptr;
   }
 
-  // TODO(distributed): make a Request for it?
   return nullptr;
 }
 

stdlib/public/Distributed/DistributedActorSystem.swift

@@ -185,10 +185,7 @@ extension DistributedActorSystem {
     // pretty formatted name of the call target, but perhaps we can do better.
 
     // Get the expected parameter count of the func
-    guard let targetName = target.identifier else {
-      throw ExecuteDistributedTargetError(
-        message: "Unable to extract target identifier from remote call target: \(target)")
-    }
+    let targetName = target.identifier
     let nameUTF8 = Array(targetName.utf8)
 
     // Gen the generic environment (if any) associated with the target.
@@ -351,7 +348,7 @@ public struct RemoteCallTarget: CustomStringConvertible {
   }
 
   /// The underlying identifier of the target, returned as-is.
-  public var identifier: String? {
+  public var identifier: String {
     return _identifier
   }
 

test/Distributed/Runtime/distributed_actor_remoteCall.swift

@@ -304,39 +304,39 @@ func test() async throws {
 
   try await system.executeDistributedTarget(
       on: local,
-      target: RemoteCallTarget(_mangledName: emptyName),
+      target: RemoteCallTarget(emptyName),
       invocationDecoder: &emptyInvocation,
       handler: FakeResultHandler()
   )
   // CHECK: RETURN: ()
 
   try await system.executeDistributedTarget(
       on: local,
-      target: RemoteCallTarget(_mangledName: helloName),
+      target: RemoteCallTarget(helloName),
       invocationDecoder: &emptyInvocation,
       handler: FakeResultHandler()
   )
   // CHECK: RETURN: Hello, World!
 
   try await system.executeDistributedTarget(
       on: local,
-      target: RemoteCallTarget(_mangledName: answerName),
+      target: RemoteCallTarget(answerName),
       invocationDecoder: &emptyInvocation,
       handler: FakeResultHandler()
   )
   // CHECK: RETURN: 42
 
   try await system.executeDistributedTarget(
       on: local,
-      target: RemoteCallTarget(_mangledName: largeResultName),
+      target: RemoteCallTarget(largeResultName),
       invocationDecoder: &emptyInvocation,
       handler: FakeResultHandler()
   )
   // CHECK: RETURN: LargeStruct(q: "question", a: 42, b: 1, c: 2.0, d: "Lorum ipsum")
 
   try await system.executeDistributedTarget(
       on: local,
-      target: RemoteCallTarget(_mangledName: enumResultName),
+      target: RemoteCallTarget(enumResultName),
       invocationDecoder: &emptyInvocation,
       handler: FakeResultHandler()
   )
@@ -350,7 +350,7 @@ func test() async throws {
   var echoDecoder = echoInvocation.makeDecoder()
   try await system.executeDistributedTarget(
       on: local,
-      target: RemoteCallTarget(_mangledName: echoName),
+      target: RemoteCallTarget(echoName),
       invocationDecoder: &echoDecoder,
       handler: FakeResultHandler()
   )
@@ -365,7 +365,7 @@ func test() async throws {
   var generic1Decoder = generic1Invocation.makeDecoder()
   try await system.executeDistributedTarget(
     on: local,
-    target: RemoteCallTarget(_mangledName: generic1Name),
+    target: RemoteCallTarget(generic1Name),
     invocationDecoder: &generic1Decoder,
     handler: FakeResultHandler()
   )
@@ -383,7 +383,7 @@ func test() async throws {
   var generic2Decoder = generic2Invocation.makeDecoder()
   try await system.executeDistributedTarget(
     on: local,
-    target: RemoteCallTarget(_mangledName: generic2Name),
+    target: RemoteCallTarget(generic2Name),
     invocationDecoder: &generic2Decoder,
     handler: FakeResultHandler()
   )
@@ -404,7 +404,7 @@ func test() async throws {
   var generic3Decoder = generic3Invocation.makeDecoder()
   try await system.executeDistributedTarget(
     on: local,
-    target: RemoteCallTarget(_mangledName: generic3Name),
+    target: RemoteCallTarget(generic3Name),
     invocationDecoder: &generic3Decoder,
     handler: FakeResultHandler()
   )
@@ -426,7 +426,7 @@ func test() async throws {
   var generic4Decoder = generic4Invocation.makeDecoder()
   try await system.executeDistributedTarget(
     on: local,
-    target: RemoteCallTarget(_mangledName: generic4Name),
+    target: RemoteCallTarget(generic4Name),
     invocationDecoder: &generic4Decoder,
     handler: FakeResultHandler()
   )
@@ -450,7 +450,7 @@ func test() async throws {
   var generic5Decoder = generic5Invocation.makeDecoder()
   try await system.executeDistributedTarget(
     on: local,
-    target: RemoteCallTarget(_mangledName: generic5Name),
+    target: RemoteCallTarget(generic5Name),
     invocationDecoder: &generic5Decoder,
     handler: FakeResultHandler()
   )
@@ -473,7 +473,7 @@ func test() async throws {
   var genericOptDecoder = genericOptInvocation.makeDecoder()
   try await system.executeDistributedTarget(
     on: local,
-    target: RemoteCallTarget(_mangledName: genericOptionalName),
+    target: RemoteCallTarget(genericOptionalName),
     invocationDecoder: &genericOptDecoder,
     handler: FakeResultHandler()
   )
@@ -488,7 +488,7 @@ func test() async throws {
   var decodeErrDecoder = decodeErrInvocation.makeDecoder()
   try await system.executeDistributedTarget(
     on: local,
-    target: RemoteCallTarget(_mangledName: expectsDecodeErrorName),
+    target: RemoteCallTarget(expectsDecodeErrorName),
     invocationDecoder: &decodeErrDecoder,
     handler: FakeResultHandler()
   )