[Constraint solver] Don't count suppressed diagnostics against the score.

Author: DougGregor

lib/Sema/CSFix.cpp

@@ -46,8 +46,10 @@ Optional<ScoreKind> ConstraintFix::affectsSolutionScore() const {
     return SK_Fix;
 
   case FixBehavior::DowngradeToWarning:
-  case FixBehavior::Suppress:
     return SK_DisfavoredOverload;
+
+  case FixBehavior::Suppress:
+    return None;
   }
 }
 

test/Concurrency/preconcurrency_overload.swift

@@ -9,11 +9,22 @@ extension Future {
   func flatMap<NewValue>(_ callback: @escaping @Sendable (T) -> Future<NewValue>) -> Future<NewValue> { // #1
     fatalError()
   }
+
+  @preconcurrency
+  public func flatMapErrorThrowing(_ callback: @escaping @Sendable (Error) throws -> T) -> Future<T> {
+    fatalError("")
+  }
 }
 
 extension Future {
   @available(*, deprecated, message: "")
   func flatMap<NewValue>(file: StaticString = #file, line: UInt = #line, _ callback: @escaping (T) -> Future<NewValue>) -> Future<NewValue> { // #2
     return self.flatMap(callback)
   }
+
+  @inlinable
+  @available(*, deprecated, message: "Please don't pass file:line:, there's no point.")
+  public func flatMapErrorThrowing(file: StaticString = #file, line: UInt = #line, _ callback: @escaping (Error) throws -> T) -> Future<T> {
+    return self.flatMapErrorThrowing(callback)
+  }
 }